CLM: Reminders for potentially outdated content#330
Conversation
| @provider(IVocabularyFactory) | ||
| def review_users_vocabulary(context): | ||
| acl_users = context.acl_users | ||
| reviewers = acl_users.getGroupById("Reviewers") |
There was a problem hiding this comment.
This group doesn't exist (I think?). For the first implementation I would make the field use the plone.app.vocabularies.Users vocabulary so any user can be selected. Then we can come back and make it smarter later.
You can use plone.api for this: https://6.docs.plone.org/plone.api/group.html#get-group-members
There was a problem hiding this comment.
@davisagli "Reviewers" is correct. plone.api.user.get_users(groupname="Reviewers") returns all members of this group. Should I use SimpleVocabulary([SimpleTerm]) here as well?
davisagli
force-pushed
the
content-review
branch
from
1a4504b to
2d9a4ba
Compare
davisagli
left a comment
davisagli
left a comment
There was a problem hiding this comment.
@Tishasoumya-02 Nice job overall. I left a lot of comments, that means it was good enough for me to do a detailed review.
There was a problem hiding this comment.
@sneridagh Can we make it possible to add a new entry to this menu without shadowing More?
There was a problem hiding this comment.
@sneridagh Can we make it possible to add the content review sidebar without shadowing Toolbar?
3 participants
https://gitlab.kitconcept.io/kitconcept/distribution-kitconcept-intranet/-/issues/216