WIP Update kitconcept.solr with FHNW improvements#314
Open
reekitconcept wants to merge 7 commits into
Open
Conversation
reekitconcept
force-pushed
the
update-kitconcept-solr-with-fhnw-improvements
branch
from
96544c2 to
24da6a0
Compare
reekitconcept
changed the title
reekitconcept
force-pushed
the
update-kitconcept-solr-with-fhnw-improvements
branch
3 times, most recently
from
a02aba8 to
375d3a0
Compare
reekitconcept
changed the title
reekitconcept
force-pushed
the
update-kitconcept-solr-with-fhnw-improvements
branch
5 times, most recently
from
7636cb9 to
30a545a
Compare
Member
Author
|
Highlighting improvements from the new branch now works out-of-the-box. Previously:
Now:
Both are returned in dedicated fields (highlighting_title, highlighting_description) 
The other improvements regarding suggestions, "Did you mean to..." are not used as we continue using the default suggest workflow from the frontend. Fhnw has its customized frontend to use these. We might at some point want to use it too, but likely only in a next major version with a redesign. |
reekitconcept
force-pushed
the
update-kitconcept-solr-with-fhnw-improvements
branch
from
30a545a to
b0560ce
Compare
davisagli
reviewed
Jan 29, 2026
| "pas.plugins.oidc==2.0.0", | ||
| "collective-solr==10.0.0", | ||
| "kitconcept.solr==2.0.0a9", | ||
| "kitconcept.solr @ git+https://github.com/kitconcept/kitconcept.solr.git@fhnw-features-e5ac96d#subdirectory=backend", |
Member
There was a problem hiding this comment.
Needs to be updated with an actual release before we merge this.
| "prettier": "prettier --check 'packages/**/src/**/*.{js,jsx,ts,tsx}' '!packages/volto-solr/**'", | ||
| "prettier:fix": "prettier --write 'packages/**/src/**/*.{js,jsx,ts,tsx}' '!packages/volto-solr/**'", | ||
| "stylelint": "stylelint 'packages/**/src/**/*.{css,scss,less}' '!packages/volto-solr/**' --allow-empty-input", | ||
| "stylelint:fix": "stylelint 'packages/**/src/**/*.{css,scss,less}' '!packages/volto-solr/**' --fix --allow-empty-input", |
Member
There was a problem hiding this comment.
@reekitconcept We should add this permanently in frontend/.eslintignore instead of here. I'm not sure if we have something similar for prettier and stylelint.
Member
Author
There was a problem hiding this comment.
I agree - we use the same from fhnw for eslint.
Re prettier and stylelint: I'm not sure what's best.
- Update kitconcept.solr - Add Solr highlighting fields configuration - Add upgrade step
…e blocks-indexing.cy.js less brittle
reekitconcept
force-pushed
the
update-kitconcept-solr-with-fhnw-improvements
branch
from
98fe9e3 to
de76933
Compare
reekitconcept
force-pushed
the
update-kitconcept-solr-with-fhnw-improvements
branch
from
de76933 to
e4f0374
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan