Skip to content

Fix: update box and height to use responsive sizes properly #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krishan711 merged 1 commit into from
Jan 30, 2026
Merged

Fix: update box and height to use responsive sizes properly #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
### Added

### Changed
- [MINOR] Correction for using `childSizeResponsive.base` size in `EqualGrid`
- [MINOR] Correction for using `sizeResponsive.base` size in `EqualGrid`
- [MINOR] Correction for using `heightResponsive.base`, `widthResponsive.base` size in `EqualGrid`, `Box` and `Stack`
Comment on lines +13 to +14
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changelog entry refers to sizeResponsive.base in EqualGrid, but the component API uses childSizeResponsive.base (see src/layouts/equalGrid/component.tsx:19-25). To avoid confusion for consumers, consider updating the wording to match the actual prop names and to only mention heightResponsive.base / widthResponsive.base for components that actually expose those props (Box and Stack, not EqualGrid).

Suggested change
- [MINOR] Correction for using `sizeResponsive.base` size in `EqualGrid`
- [MINOR] Correction for using `heightResponsive.base`, `widthResponsive.base` size in `EqualGrid`, `Box` and `Stack`
- [MINOR] Correction for using `childSizeResponsive.base` size in `EqualGrid`
- [MINOR] Correction for using `heightResponsive.base`, `widthResponsive.base` size in `Box` and `Stack`

Copilot uses AI. Check for mistakes.

### Removed

Expand Down
4 changes: 2 additions & 2 deletions src/layouts/stack/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,8 @@ export function Stack({
const paddingBottom = (props.paddingEnd && direction === Direction.Vertical) ? props.paddingEnd : undefined;
const paddingLeft = (props.paddingStart && direction === Direction.Horizontal) ? props.paddingStart : undefined;
const paddingRight = (props.paddingEnd && direction === Direction.Horizontal) ? props.paddingEnd : undefined;
const height = props.height || (isFullHeight ? '100%' : 'auto');
const width = props.width || (isFullWidth ? '100%' : 'auto');
const height = props.height ?? props.heightResponsive?.base ?? (isFullHeight ? '100%' : 'auto');
const width = props.width ?? props.widthResponsive?.base ?? (isFullWidth ? '100%' : 'auto');
const maxHeight = props.maxHeight ?? null;
const maxWidth = props.maxWidth ?? null;
const minHeight = props.minHeight ?? null;
Expand Down
4 changes: 2 additions & 2 deletions src/particles/box/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ export function Box({
isFullWidth = true,
...props
}: IBoxProps): React.ReactElement {
const height = props.height || (props.isFullHeight ? '100%' : 'auto');
const width = props.width || (isFullWidth ? '100%' : 'auto');
const height = props.height ?? props.heightResponsive?.base ?? (props.isFullHeight ? '100%' : 'auto');
const width = props.width ?? props.widthResponsive?.base ?? (isFullWidth ? '100%' : 'auto');
const blockType = width === '100%' ? 'block' : 'flex';
const combinedStyles: React.CSSProperties = {
...props.style,
Expand Down
Loading