Feature: forward all the themes#239
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds SCSS @forward statements for all component style modules to enable consumers to access component mixins and variables with namespaced prefixes. The main change systematically adds @forward statements alongside existing @use statements in the central styles aggregation file, making component style internals (mixins, functions, variables) available to consuming applications.
Key Changes
- Added
@forwardstatements with namespace prefixes (as componentName-*) for all 43 component style modules insrc/styles/all.scss - Added
cursor: pointerdeclaration to the clickable state inlistItemcomponent's theme layer
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/styles/all.scss |
Added @forward statements with prefixed namespacing for all particles, layouts, atoms, molecules, and wrappers style modules to expose their mixins and variables to consumers |
src/atoms/listItem/styles.scss |
Added cursor: pointer to the clickable variant in the theme layer |
| @include box.focusable; | ||
| padding: $padding-wide $padding-wide; | ||
| &.clickable { | ||
| cursor: pointer; |
There was a problem hiding this comment.
This cursor: pointer declaration duplicates the same property already defined in the kiba-structure layer at line 13. While the CSS Architecture guidelines suggest that cursor belongs in the kiba-theme layer, adding it here creates a redundant declaration. Consider removing this line since the cursor is already set for the clickable state in the structure layer.
| cursor: pointer; |
Description
Screenshots:
Checklist: