Skip to content

Fiddle: update inputWrapper to not auto full width #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krishan711 merged 1 commit into from
Dec 11, 2025
Merged

Fiddle: update inputWrapper to not auto full width #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/atoms/inputWrapper/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,14 @@ import { HidingView } from '../../wrappers';
export interface IInputWrapperProps extends IComponentProps, ISingleAnyChildProps {
messageText?: string;
isEnabled?: boolean;
isFullWidth?: boolean;
onClicked?: () => void;
}

export function InputWrapper({
className = '',
variant = 'default',
isFullWidth = false,
...props
}: IInputWrapperProps): React.ReactElement {
const [isFocussed, setIsFocussed] = React.useState(false);
Expand All @@ -34,7 +36,7 @@ export function InputWrapper({
return (
<div
id={props.id}
className={getClassName(InputWrapper.displayName, className, props.messageText && 'message-showing', isFocussed && 'focus', !props.isEnabled && 'disabled', ...(variant?.split('-') || []))}
className={getClassName(InputWrapper.displayName, className, props.messageText && 'message-showing', isFocussed && 'focus', !props.isEnabled && 'disabled', isFullWidth && 'full-width', ...(variant?.split('-') || []))}
Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS class name should be 'fullWidth' (camelCase) instead of 'full-width' (kebab-case) to match the library's established naming convention used in other components like Button, IconButton, LinkBase, and SelectableView.

Suggested change
className={getClassName(InputWrapper.displayName, className, props.messageText && 'message-showing', isFocussed && 'focus', !props.isEnabled && 'disabled', isFullWidth && 'full-width', ...(variant?.split('-') || []))}
className={getClassName(InputWrapper.displayName, className, props.messageText && 'message-showing', isFocussed && 'focus', !props.isEnabled && 'disabled', isFullWidth && 'fullWidth', ...(variant?.split('-') || []))}

Copilot uses AI. Check for mistakes.
style={props.style}
>
{/* eslint-disable jsx-a11y/no-static-element-interactions, jsx-a11y/no-noninteractive-tabindex */}
Expand Down
5 changes: 4 additions & 1 deletion src/atoms/inputWrapper/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@
.KibaInputWrapper {
display: flex;
flex-direction: column;
width: 100%;

&.full-width {
Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS class name 'full-width' uses kebab-case, which is inconsistent with the library's established naming convention. Other components (Button, IconButton, LinkBase, SelectableView) use camelCase 'fullWidth' for the same functionality. Please update to 'fullWidth' to maintain consistency.

Suggested change
&.full-width {
&.fullWidth {

Copilot uses AI. Check for mistakes.
width: 100%;
}

&.disabled {
cursor: not-allowed;
Expand Down
Loading