Fiddle: update deployment structure#235
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restructures the GitHub Actions deployment workflows by separating package deployment concerns from documentation deployment, improving organization and clarity of the deployment pipeline.
- Splits deployment responsibilities: package/release creation moved to
deploy.yml, documentation deployment isolated todeploy-docs.yml - Adds tag-based triggers to enable versioned releases alongside continuous deployment
- Consolidates the
create-releasejob into the main deployment workflow
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/deploy.yml |
Renamed from package-next deployment to unified package deployment; added tag trigger support, conditional npm publishing for tags vs main branch, and GitHub release creation |
.github/workflows/deploy-docs.yml |
Renamed from Release workflow; added main branch trigger and workflow_dispatch; moved docs deployment jobs from deploy.yml; removed create-release job (moved to deploy.yml) |
Comments suppressed due to low confidence (4)
.github/workflows/deploy-docs.yml:27
- The
docker/setup-buildx-action@v1anddocker/build-push-action@v2actions are outdated. Consider upgrading todocker/setup-buildx-action@v3anddocker/build-push-action@v5respectively for better performance and security.
.github/workflows/deploy-docs.yml:11 - The
deploy-docs-nextjob runs on every push tomainand every tag push, which may not be intended. Thenextdocs should typically only deploy on pushes tomain(development builds), not on tag releases. Consider adding a condition:
deploy-docs-next:
if: github.ref == 'refs/heads/main'This prevents deploying the -next docs when creating versioned releases.
.github/workflows/deploy-docs.yml:17
- The
actions/checkout@v2action is outdated. Consider upgrading toactions/checkout@v4which is the current stable version with improved performance and security fixes.
.github/workflows/deploy-docs.yml:19 - The
docker/login-action@v2action is outdated. Consider upgrading todocker/login-action@v3which includes security improvements and bug fixes.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
.github/workflows/deploy-docs.yml:11
- The
deploy-docs-nextjob runs on every push to main and for all tags, but it should likely only run for pushes to the main branch. Consider adding a conditionif: github.ref == 'refs/heads/main'to this job to prevent it from running on tag pushes, similar to howdeploy-docsonly runs on tags.
.github/workflows/deploy-docs.yml:35 - The
run-docs-nextjob will also run on tag pushes since its dependencydeploy-docs-nextruns on tags. Consider addingif: github.ref == 'refs/heads/main'to this job to prevent it from running unnecessarily on tag pushes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshots:
Checklist: