Fiddle: update build-js to add style linting#233
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the build tooling to add style linting (stylelint) support by upgrading the @kibalabs/build package from version 0.13.3-next.13 to ^0.13.3-next.14. The changes add stylelint disable comments to existing SCSS files to address legitimate CSS patterns, and include new documentation about creating custom components.
Key Changes
- Updated
@kibalabs/builddependency to enable stylelint support - Added stylelint disable comments to SCSS files for intentional CSS overrides and browser fallbacks
- Added "Creating Custom Components" section to README with example code
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated @kibalabs/build dependency to version 0.13.3-next.14 |
| package-lock.json | Updated dependency lockfile with new stylelint-related packages |
| src/styles/reset.scss | Added stylelint disable comments for intentional font property overrides and duplicate selectors in reset styles |
| src/styles/global.scss | Added stylelint disable comment for browser fallback pattern (pixelated image rendering) |
| src/molecules/carousel/styles.scss | Added stylelint disable comment for IE11 overflow fallback |
| src/atoms/iconButton/styles.scss | Added stylelint disable comment for background shorthand override |
| src/atoms/button/styles.scss | Added stylelint disable comment for background shorthand override |
| README.md | Added new "Creating Custom Components" section with usage examples |
| When creating custom components in your project, extend `IComponentProps` and pass the styling props to your root element: | ||
|
|
||
| ```tsx | ||
| import { IComponentProps, Stack, Text } from '@kibalabs/ui-react'; |
There was a problem hiding this comment.
Missing import for Direction enum. The code example uses Direction.Vertical but doesn't import it. Should add Direction to the import statement:
import { IComponentProps, Stack, Text, Direction } from '@kibalabs/ui-react';
Suggested change
| import { IComponentProps, Stack, Text } from '@kibalabs/ui-react'; | |
| import { IComponentProps, Stack, Text, Direction } from '@kibalabs/ui-react'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshots:
Checklist: