Fiddle: corrections for new styling + fix storybook#10
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the toast component styling and fixes Storybook configuration issues. It adds comprehensive theme support with CSS custom properties for toast variants (success, error, warning, info) and updates the Storybook setup to properly display toasts in the development environment.
- Adds complete toast theming with CSS custom properties for colors, padding, borders, and shadows with sensible default values
- Fixes Storybook by consolidating UI library imports and adding ToastContainer decorator for proper toast rendering
- Updates @kibalabs/build dependency and corrects peerDependencies version requirement
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/styles.scss | Adds toast container max-width override, white-space property, and comprehensive theme layer with CSS custom properties for toast variants |
| package.json | Updates @kibalabs/build to 0.13.3-next.13 |
| package-lock.json | Updates @kibalabs/build version and corrects @kibalabs/ui-react peerDependency from >=0.13.3-next.12 to >=0.11.3-next.18 |
| .storybook/preview.tsx | Consolidates @kibalabs/ui-react imports to single dist/index.css file and adds ToastContainer decorator for proper toast rendering in stories |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshots:
Checklist: