Skip to content

Fiddle: add blockNumber to EthClient.multicall#130

Merged
krishan711 merged 4 commits into
mainfrom
blocknum
Apr 5, 2026
Merged

Fiddle: add blockNumber to EthClient.multicall#130
krishan711 merged 4 commits into
mainfrom
blocknum

Conversation

@krishan711
Copy link
Copy Markdown
Contributor

Description

Screenshots:

Checklist:

  • I have updated the CHANGELOG with a summary of my changes

Copilot AI review requested due to automatic review settings April 5, 2026 08:44
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the EthClient multicall API to support historical reads by allowing callers to specify a blockNumber, ensuring multicall results can be fetched at a specific block height.

Changes:

  • Add optional blockNumber parameter to EthClientInterface.multicall and forward it through both fallback per-call execution and the Multicall3 aggregate call.
  • Refine Web3EthClient.get_log_entries to build FilterParams conditionally (omitting None fields) and improve typing.
  • Apply small lint/style adjustments in utilities/exceptions and record the multicall API change in the changelog.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File Description
core/web3/eth_client.py Adds blockNumber support to multicall and refactors log filter params construction.
core/util/file_util.py Adds noqa suppression for async-lint warnings on sync filesystem calls inside async wrappers.
core/exceptions.py Simplifies default message/exceptionType assignment using or.
CHANGELOG.md Documents the new blockNumber parameter on EthClient.multicall.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread core/web3/eth_client.py
Comment thread core/web3/eth_client.py
@krishan711 krishan711 merged commit abf533a into main Apr 5, 2026
4 checks passed
@krishan711 krishan711 deleted the blocknum branch April 5, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants