Fiddle: add blockNumber to EthClient.multicall#130
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the EthClient multicall API to support historical reads by allowing callers to specify a blockNumber, ensuring multicall results can be fetched at a specific block height.
Changes:
- Add optional
blockNumberparameter toEthClientInterface.multicalland forward it through both fallback per-call execution and the Multicall3 aggregate call. - Refine
Web3EthClient.get_log_entriesto buildFilterParamsconditionally (omittingNonefields) and improve typing. - Apply small lint/style adjustments in utilities/exceptions and record the multicall API change in the changelog.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| core/web3/eth_client.py | Adds blockNumber support to multicall and refactors log filter params construction. |
| core/util/file_util.py | Adds noqa suppression for async-lint warnings on sync filesystem calls inside async wrappers. |
| core/exceptions.py | Simplifies default message/exceptionType assignment using or. |
| CHANGELOG.md | Documents the new blockNumber parameter on EthClient.multicall. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshots:
Checklist: