fix: fix layer toggle in dual map view#3464
Merged
Merged
Conversation
Signed-off-by: Ihor Dykhta <ihordykhta@Ihors-MacBook-Pro.local>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a regression in split/dual map view where layer visibility could be toggled on but not toggled off, caused by the checkbox refactor changing the underlying hidden input to type="radio" for radio-styled checkboxes.
Changes:
- Force the underlying hidden input in
Checkboxto always render astype="checkbox"to ensure uncheck toggles fireonChangeas expected.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lixun910
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #3462
Fix regression where layers can be turned on but not off in split map view. The Checkbox component refactor (#3440) inadvertently changed the hidden input type from "checkbox" to "radio" when the type prop is "radio", preventing onChange from firing on uncheck.