fix: heatmap layer - remove unused uniform blocks on mobile#3463
Merged
Conversation
Signed-off-by: Ihor Dykhta <ihordykhta@Ihors-MacBook-Pro.local>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses mobile shader compilation crashes in the deck.gl-based heatmap layer by ensuring an unused (but spec-invalid on some GLES compilers) uniform block is not injected into the heatmap’s transform shaders, while preserving identical GPU output.
Changes:
- Move the “weights” shader patching into
_createWeightsTransformso it still applies when legacyAggregationLayer.updateState()bypassesgetShadersfor transform creation. - Remove the
layershader module from the weights transform (and from the max-weights transform when detected) to avoid generating the problematiclayerUniformsblock on strict mobile GPU drivers. - Keep the max-weights transform fragment shader patch in
getShaders(forcingfragColor.r = 1.0) and pair it with the same module removal when applicable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ilyabo
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #3459