Skip to content

fix: heatmap layer - remove unused uniform blocks on mobile#3463

Merged
igorDykhta merged 1 commit into
masterfrom
igr/heatmpa-mobile-fix-2
May 26, 2026
Merged

fix: heatmap layer - remove unused uniform blocks on mobile#3463
igorDykhta merged 1 commit into
masterfrom
igr/heatmpa-mobile-fix-2

Conversation

@igorDykhta
Copy link
Copy Markdown
Collaborator

  • the heatmap layer still crashes on some mobile devices
  • the layer uniform block is removed from the compiled shader, but since it was never used, the GPU output is identical -> no crash on strict mobile compilers

For #3459

Signed-off-by: Ihor Dykhta <ihordykhta@Ihors-MacBook-Pro.local>
@igorDykhta igorDykhta requested review from ilyabo and lixun910 May 26, 2026 19:15
@igorDykhta igorDykhta self-assigned this May 26, 2026
Copilot AI review requested due to automatic review settings May 26, 2026 19:15
@igorDykhta igorDykhta added the 3.3 Kepler.gl 3.3 release label May 26, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses mobile shader compilation crashes in the deck.gl-based heatmap layer by ensuring an unused (but spec-invalid on some GLES compilers) uniform block is not injected into the heatmap’s transform shaders, while preserving identical GPU output.

Changes:

  • Move the “weights” shader patching into _createWeightsTransform so it still applies when legacy AggregationLayer.updateState() bypasses getShaders for transform creation.
  • Remove the layer shader module from the weights transform (and from the max-weights transform when detected) to avoid generating the problematic layerUniforms block on strict mobile GPU drivers.
  • Keep the max-weights transform fragment shader patch in getShaders (forcing fragColor.r = 1.0) and pair it with the same module removal when applicable.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@igorDykhta igorDykhta merged commit 7bd7d22 into master May 26, 2026
9 checks passed
@igorDykhta igorDykhta deleted the igr/heatmpa-mobile-fix-2 branch May 26, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.3 Kepler.gl 3.3 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants