[Feat] timeline zoom & precision controls in enlarged time filter#3460
Merged
Conversation
Signed-off-by: Ihor Dykhta <ihordykhta@Ihors-MacBook-Pro.local>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds cursor-centric zoom and precision navigation to the enlarged bottom time filter timeline, including wheel/pinch zoom behaviors, keyboard panning, and UI feedback when the visible timeline domain is narrowed.
Changes:
- Implement local
timelineDomainstate inTimeWidgetwith wheel/pinch zoom, keyboard panning, clamping, and a “Showing … Reset” status bar. - Improve slider/throttle cleanup and histogram rendering behavior to better support zoomed/highlighted ranges.
- Add/extend tape/enzyme tests and update playback docs to describe the new interactions.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/components/src/filters/time-widget.tsx |
Adds zoom/pan interactions, timeline-domain state, and reset status UI for enlarged timeline. |
src/components/src/common/time-range-slider.tsx |
Cancels throttled onChange on unmount to prevent lingering timers. |
src/components/src/common/range-brush.tsx |
Adjusts brush selection opacity. |
src/components/src/common/histogram-plot.tsx |
Simplifies bar-in-range logic and adds clipping to prevent bar overflow during zoomed views. |
test/node/utils/timeline-zoom-test.js |
New unit tests for timeline zoom/clamp helper logic. |
test/node/utils/index.js |
Registers the new node utility test. |
test/browser/components/filters/time-widget-test.js |
Adds browser/component tests for reset visibility, container render, and keyboard panning. |
docs/user-guides/h-playback.md |
Documents the new zoom & precision controls for the enlarged timeline. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Thanks for picking this up and the credit, @igorDykhta! Would you mind adding a
trailer to the merge/squash commit so the contribution is tracked on the commit itself? Happy to help if anything in the original parts needs follow-up. |
Signed-off-by: Ihor Dykhta <ihordykhta@Ihors-MacBook-Pro.local> Co-authored-by: Jakob Malmo <112383651+jmalmo@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
igorDykhta
force-pushed
the
igr/timeline-improvements-input
branch
from
5c8faf5 to
c2fdeb6
Compare
lixun910
approved these changes
May 25, 2026
Signed-off-by: Ihor Dykhta <ihordykhta@Ihors-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.