Skip to content

Compatibility with entirety of Genius; Song Search based on Title + Artist#10

Open
yuichitlo wants to merge 13 commits intokenshiro-o:masterfrom
yuichitlo:master
Open

Compatibility with entirety of Genius; Song Search based on Title + Artist#10
yuichitlo wants to merge 13 commits intokenshiro-o:masterfrom
yuichitlo:master

Conversation

@yuichitlo
Copy link
Copy Markdown

In order to accommodate Genius' growing database and searches outside of rap and rock, everything has been generalized to http://genius.com and searches can be refined by the combination of title and artist information. This works much better as you filter out songs of the same title within a genre and are more likely to get a correct result.

I also thought renaming the project would make sense! Thanks for creating this API for working with Genius!

@kenshiro-o
Copy link
Copy Markdown
Owner

@yuichitlo Sorry for the super late getting back! It seems I took too long a break from this project.
Thanks for contributing!

I have had a quick skim through your code. It seems you commented out a few portions of code and moved stuff from my constants directly inline within the actual code logic. I am honestly not a big fan of it but would be keen to read more about your motivation.

By the way your changes seem to have broken the build so I would not be able to merge unless the build is fixed.
However, I will keep reading your changes and review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants