Add support to override session:parameter#490
Add support to override session:parameter#490lievendf wants to merge 2 commits intokenherring:mainfrom
Conversation
kenherring
left a comment
There was a problem hiding this comment.
I'm not opposed to the concept of allowing overrides for session:parameter, but I'm confused as why we needed to essentially rename ABLUnitCore.p to ABLUnitCore_sub.p. Can you explain more about this approach?
My concern is twofold:
- This is doing something to fight against using propath functionality as intended.
- The diff is difficult to review.
|
Hi Ken, As detailed in #488 we have our own When specifying startup parameters for OpenEdge processes, you can specify the same parameter multiple times, which results in the last occurrence to be used effectively.
There
In order to no longer directly depend on Why the rename? Because that's the only way for Git to track the code changes back to the original file. If I had done this in 1 commit instead of 2, Git would see the new ABLUnitCore_sub.p as a new file with no "connection" to the original code in The actual code changes in this PR and the proposed change above are minimal and stay backwards compatible with existing functionality, while providing a huge benefit in our workflow. |
d47e6f1 to
ba2ec1c
Compare
Renamed ABLUnitCore.p to ABLUnitCore_sub.p and added an input sessionParameter
Call renamed ABLUnitCore_sub.p from stub ABLUnitCore.p passing in session:parameter.
ba2ec1c to
94f03db
Compare
This change adds support to override
session:parameterthat was (hardcoded) used inABLUnitCore.pandcreateDatabaseAliases.p.Changes in ABL code only.
I've rerun all existing tests and all succeed, except for the ones that are supposed to fail 😉.
See #488 for a use case.