Open
Conversation
The current ctest suite for the cast operator requires several improvements: 1. **Missing repack coverage:** Tests for repack functionality are not yet implemented. These should be added to cover various dimensions. 2. **Unsupported bool type for different ISAs:** Support for the boolean type across different ISAs is needed. The main workload is expected to be in , with minor changes to the test scripts. 3. **Adapt to new cast interface:** Ctests need to be regenerated to align with the new cast interface once the recent implementation is merged.
cast, pack, unpack stay right
Some types still need cast
Binary for other ops not tested
But some additional changes on binary_test_genertor.py if cannot run, just roll binary generator to the original version
for uint32 sub, if result is negtive, ntt_output would be neg, but double result cast to uint would be 0
Uint64 cannot be casted to fp8 on arm platform
ZenusZhang
force-pushed
the
test_binary
branch
from
5a143a1 to
d1692ad
Compare
ZenusZhang
force-pushed
the
test_binary
branch
from
b1ede93 to
3a3982a
Compare
ZenusZhang
force-pushed
the
test_binary
branch
from
72d7d6e to
f3da8b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ctest script about pack, unpack binary, cast.
And some fixing about the kernel error.