Add testing conventions, parallel paths, and fix agent prompt bugs#786
Open
kelos-bot[bot] wants to merge 1 commit intomainfrom
Open
Add testing conventions, parallel paths, and fix agent prompt bugs#786kelos-bot[bot] wants to merge 1 commit intomainfrom
kelos-bot[bot] wants to merge 1 commit intomainfrom
Conversation
github-actions
bot
added
needs-triage
needs-kind
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
kelos-bot
bot
changed the title
kelos-bot bot
pushed a commit
that referenced
this pull request
Mar 29, 2026
Add three new agent conventions from recent PR review feedback: 1. Per-TaskSpawner configuration should be CRD fields, not controller flags (PR #838 - gjkim42 review) 2. CRD API backward compatibility - never rename JSON field tags (PR #838 - P1 review finding) 3. Gate optional CRDs behind Helm values flags (PR #821 - PodMonitoring broke installs on clusters without monitoring.googleapis.com) Also includes previously proposed conventions from PR #786: - Consistent guidance across surfaces - Provider-agnostic API design - Idiomatic Helm values - Deploy-dev workflow sync - Controller-driven migration - Release note user action requirements Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kelos-bot
bot
force-pushed
the
kelos-config-update-latest
branch
from
bcdeef3 to
7ade17e
Compare
kelos-bot
bot
changed the title
Collaborator
|
/kelos pick-up |
Author
|
🤖 Kelos Task Status Task |
kelos-bot
bot
added
kind/cleanup
and removed
needs-kind
Author
|
🤖 Kelos Agent @gjkim42 /kelos needs-input Rebased on origin/main (was already up to date). Added The only failing CI check is Ready for re-review. |
kelos-bot
bot
force-pushed
the
kelos-config-update-latest
branch
from
7ade17e to
782ce1c
Compare
kelos-bot
bot
changed the title
kelos-bot
bot
changed the title
kelos-bot
bot
changed the title
kelos-bot
bot
force-pushed
the
kelos-config-update-latest
branch
from
0871329 to
6379545
Compare
kelos-bot
bot
changed the title
kelos-bot
bot
changed the title
kelos-bot
bot
force-pushed
the
kelos-config-update-latest
branch
from
6f6241c to
41ed5c4
Compare
kelos-bot
bot
changed the title
- Add parallel implementation paths convention to AGENTS.md, agentconfig, and workers agent config - Add testing conventions: avoid time.Sleep in concurrency tests, defer cleanup of global state overrides - Add parallel paths and testing checks to reviewer agent checklist - Fix gh pr edit using issue number instead of defaulting to current branch in workers prompt - Remove redundant git checkout from squash-commits prompt (Kelos already checks out the branch) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kelos-bot
bot
force-pushed
the
kelos-config-update-latest
branch
from
41ed5c4 to
5f6baa8
Compare
kelos-bot
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates agent configuration based on review feedback from recent PRs:
New convention: Consistent parallel implementation paths — When the same feature is implemented in multiple code paths (e.g., polling source and webhook handler), keep the logic, data structures, and field checks consistent. Added to
AGENTS.md,agentconfig.yaml, andkelos-workers.yaml.spawnerNeedsChangedFiles(webhook) checks fewer template variable fields thantemplateReferencesChangedFiles(polling), missingMetadata.LabelsandMetadata.Annotationschecks. PR fix: populate Branch for issue_comment webhook events on pull requests #892 review noted divergence between GitHub and Linear enrichment placement (unconditional vs inside loop).New convention: Test concurrency without
time.Sleep— Use deterministic synchronization (channels,sync.WaitGroup, polling with timeout) instead of fixed sleeps. Added toAGENTS.md,agentconfig.yaml, andkelos-workers.yaml.time.Sleep(50ms)in singleflight concurrency tests as a flakiness risk on slow CI runners.New convention: Defer cleanup of global state overrides in tests — When overriding global state (
os.Stdin, env vars), immediatelydeferthe restoration. Added toAGENTS.md,agentconfig.yaml, andkelos-workers.yaml.deferforos.Stdinrestoration in tests, risking global state leaks on early test failure.Reviewer agent checklist updates — Added parallel paths check and testing convention checks to the reviewer agent's review checklist so these patterns are caught in future reviews.
Fix
gh pr edit {{.Number}}bug in kelos-workers prompt — In the workers TaskSpawner context,{{.Number}}is the issue number, not the PR number. Changed to usegh pr editwithout a number (defaults to current branch's PR).Remove redundant
git checkoutfrom kelos-squash-commits prompt — Kelos already checks out the branch automatically viabranch: "{{.Branch}}"in the task template.git checkoutin multiple agent prompts.Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
All changes are backed by specific PR review findings. No speculative rules added.
Does this PR introduce a user-facing change?