Fixup openapi controller eviction#4142
Conversation
kcp-ci-bot
added
release-note
| // event being observed and ordered before the LogicalCluster delete. When that | ||
| // ordering breaks the bucket leaks 100KB–1MB per CRD version forever. See | ||
| // https://github.com/kcp-dev/kcp/issues/4071. | ||
| func installOpenAPIV3Evictor(informer corev1alpha1informers.LogicalClusterClusterInformer, controller *openapiv3.Controller) { |
There was a problem hiding this comment.
This function is getting very similar to the ones in other prs. will need to unify them as follow-up
| "another": {"crd-c": {"v1": cached.Static(&spec3.OpenAPI{}, "etag")}}, | ||
| }, | ||
| } | ||
| c.lock = sync.Mutex{} |
Remove mutex initialization before EvictCluster call.
|
LGTM label has been added. DetailsGit tree hash: d801b1a7c0db914ba3b591c744aa9141891b8448 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ntnn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
|
@mjudeikis: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Summary
Fix openapi controller evictions of the clusters.
What Type of PR Is This?
/kind bug
Related Issue(s)
Fixes #
Release Notes