nationex: normalize additional tracking statuses#16
Open
HansDaigle wants to merge 1 commit intokarrioapi:mainfrom
Open
nationex: normalize additional tracking statuses#16HansDaigle wants to merge 1 commit intokarrioapi:mainfrom
HansDaigle wants to merge 1 commit intokarrioapi:mainfrom
Conversation
Contributor
Author
|
Recommendation for tracking normalization work: prefer when querying carrier tracking APIs (including via Karrio). We verified localized descriptions (e.g., FR) can vary in wording, while the normalized status remains stable; using English reduces parser drift and keeps mappings deterministic across carriers. |
24ecc5c to
7eef9f0
Compare
Contributor
Author
|
Tracking note/TODO: Nationex POD images are returned as base64 payloads (not URL refs). We intentionally removed image-fetching for now to avoid persisting large blobs in tracking payload/storage. Follow-up: decode base64, upload to object storage (S3/R2/etc), and persist only generated URLs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Creation/DataReceivedtopendinginstead of defaulting toin_transitunknownWhy
Nationex returns statuses like
Creation,DataReceived,OutForPickup,ReturnCompleted, and partial status variants. Without explicit mappings these can be normalized incorrectly (for example asin_transit).Validation
/Users/hansdaigle/git/tandem-monorepo/.venv/bin/python -m pytest -q plugins/nationex/tests/nationex/test_tracking.py