Fix tc-util.el overwriting the function in tc-mazegaki.el#37
Merged
Conversation
tc-util.el provides a fallback definition of `tcode-mazegaki-self-insert-or-convert`. Because it uses `boundp` instead of `fboundp` to detect an existing function, the fallback overrides the proper definition in tc-mazegaki.el when loaded after it. Replace `boundp` with `fboundp`.
|
おっと、fboundpがtならboundpもtかと思ってましたがそうでもないんですね。 他のミスもないか簡単にgrepしてみましたがなさそうです。よいと思います。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#36 の修正です。この修正があるか無いかで、#30、#32 のテストにtc-utilの機能のテストを追加できるかどうかが変わってくるので、先にこちらを見ていただけるとありがたいです。