Open
Conversation
Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Dev Container setup to better support starting the environment via the Dev Containers CLI (and likely Codespaces-style workflows), while refreshing tool versions and container tooling configuration.
Changes:
- Simplifies
make open-dev-containerto usedevcontainer uprather than separate build/open steps. - Updates
.devcontainer/devcontainer.jsonbuild args (tool versions), tweaks the Docker-outside-of-docker feature config, and changes the default VS Code extensions list. - Refactors the devcontainer Dockerfile stages (base/builder) and updates tool installation logic (kubectl/kind/argo-rollouts), plus adds a Claude install step.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| Makefile | Updates the devcontainer make target to start the container via devcontainer up. |
| .devcontainer/devcontainer.json | Bumps tool versions, tweaks docker-outside-of-docker feature settings, and changes VS Code extensions. |
| .devcontainer/Dockerfile | Reworks stages and tool installs (kubectl/kind/argo-rollouts/starship), and adds a Claude installation step. |
Comments suppressed due to low confidence (1)
.devcontainer/Dockerfile:78
- This stage installs Docker via
get.docker.comeven though the devcontainer already enablesdocker-outside-of-dockerand mounts the host Docker socket. Installing the full engine here is redundant, increases image size, and adds supply-chain risk; prefer relying on the devcontainer feature (CLI only) or explicitly install justdocker-ce-cli/docker-buildx-pluginfrom pinned APT repos.
python3-venv \
sshuttle \
tcpdump \
zsh \
&& curl -fsSL https://get.docker.com -o get-docker.sh \
&& sh get-docker.sh \
&& apt-get clean \
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
10
to
13
| "TOOLS_KIND_VERSION": "0.27.0", | ||
| "TOOLS_ISTIO_VERSION": "1.26.0", | ||
| "TOOLS_ARGO_CD_VERSION": "v1.8.4", | ||
| "TOOLS_KUBECTL_VERSION": "1.33.4" |
Comment on lines
+107
to
113
| ARG TOOLS_ISTIO_VERSION | ||
| ARG TOOLS_ARGO_CD_VERSION | ||
| ARG TOOLS_KUBECTL_VERSION | ||
|
|
||
| # Install kubectl argo plugin | ||
| RUN curl -o /usr/local/bin/kubectl-argo-rollouts -L https://github.com/argoproj/argo-rollouts/releases/${TOOLS_ARGO_CD_VERSION}/download/kubectl-argo-rollouts-linux-${ARCH} \ | ||
| RUN curl -o /usr/local/bin/kubectl-argo-rollouts -L https://github.com/argoproj/argo-rollouts/releases/download/${TOOLS_ARGO_CD_VERSION}/kubectl-argo-rollouts-linux-${ARCH} \ | ||
| && chmod +x /usr/local/bin/kubectl-argo-rollouts |
|
|
||
| ENTRYPOINT ["zsh"] No newline at end of file | ||
| # Install Claude | ||
| RUN curl -fsSL https://claude.ai/install.sh | bash |
| devcontainer build . | ||
| @devcontainer open . | ||
| @echo "Building and starting dev container..." | ||
| devcontainer up --workspace-folder . |
| "ms-windows-ai-studio.windows-ai-studio", | ||
| "GitHub.copilot", | ||
| "GitHub.copilot-chat", | ||
| "vscode:extension/anthropic.claude-code", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.