Feature/replace ava nyc enzyme and sinon for jest #8
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
|
|
||
| const testConfig = { | ||
| presets: [ | ||
| [ | ||
| '@babel/preset-env', | ||
| { | ||
| targets: { | ||
| node: 'current', | ||
| }, | ||
| }, | ||
| ], | ||
| '@babel/preset-react', | ||
| ], | ||
| }; | ||
|
|
||
| const config = { | ||
| presets: [ | ||
| [ | ||
| '@babel/preset-env', | ||
| { | ||
| targets: { | ||
| ie: '11', | ||
| }, | ||
| useBuiltIns: 'usage', | ||
| }, | ||
| ], | ||
| '@babel/preset-react', | ||
| ], | ||
| plugins: [ | ||
| '@babel/plugin-syntax-dynamic-import', | ||
| '@babel/plugin-proposal-class-properties', | ||
| '@babel/plugin-proposal-export-namespace-from', | ||
| ], | ||
| }; | ||
|
|
||
| module.exports = (api) => { | ||
| const isTest = api.env('test'); | ||
| if (isTest) return testConfig; | ||
|
|
||
| return config; | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| // Core | ||
| import React from 'react'; | ||
| // Testing | ||
| import { render } from '@testing-library/react'; | ||
| import { Consumer } from './testUtils'; | ||
|
|
||
|
|
||
| describe('I18nConsumer', () => { | ||
|
|
||
| it('should throw a warning, when try to use a consumer without provider', () => { | ||
| jest.spyOn(console, 'warn'); | ||
| render(<Consumer />); | ||
| expect(console.warn).toBeCalledTimes(1); | ||
| console.warn.mockRestore(); | ||
|
Member
There was a problem hiding this comment. this would be more precise if the test checks the content of the message
Member
Author
There was a problem hiding this comment. Rigth, I will make the change |
||
| }); | ||
|
|
||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| // Core | ||
| import React from 'react'; | ||
| // Testing | ||
| import { render } from '@testing-library/react'; | ||
| import { fetchI18n, Consumer } from './testUtils'; | ||
| // Components | ||
| import I18nProvider from './I18nProvider'; | ||
|
|
||
|
|
||
| describe('I18nProvider', () => { | ||
| it('render without errors', async () => { | ||
| const i18n = await fetchI18n(); | ||
| render(<I18nProvider i18n={i18n}><Consumer /></I18nProvider>); | ||
| }); | ||
|
|
||
| it('translates correctly', async () => { | ||
| const i18n = await fetchI18n(); | ||
| const { getByText } = render(<I18nProvider i18n={i18n}><Consumer word="Teléfono" /></I18nProvider>); | ||
| expect(getByText('Phone')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('updates correctly after setLocale', async () => { | ||
| const i18n = await fetchI18n(); | ||
| const { getByText, rerender } = render(<I18nProvider i18n={i18n}><Consumer word="Teléfono" /></I18nProvider>); | ||
| expect(getByText('Phone')).toBeInTheDocument(); | ||
| await i18n.setLocale('de'); | ||
| rerender(<I18nProvider i18n={i18n}><Consumer word="Teléfono" /></I18nProvider>); | ||
|
Member
There was a problem hiding this comment. Executing the tests, I receive this error
Member
Author
There was a problem hiding this comment. Yeah, that error is resolved in a future PR |
||
| expect(getByText('Telefon')).toBeInTheDocument(); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| // jest-dom adds custom jest matchers for asserting on DOM nodes. | ||
| // allows you to do things like: | ||
| // expect(element).toHaveTextContent(/react/i) | ||
| // learn more: https://github.com/testing-library/jest-dom | ||
| require('@testing-library/jest-dom/extend-expect'); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature seems to try to resolve a conditional environment setting,
To preserve the project settings as much as possible and keep it centralized, I suggest follow the previous method using a Babel feature to solve this problem.
https://babeljs.io/docs/en/6.26.3/babelrc#env-option
Also recommend not include this commit to keep the tree changes clean and simple (rebase from the begining of this PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't find any way to do this with
package.json, can you show me a example?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the configuration available in .babelrc are compatible inside the package.sjon babel declaration.
https://babeljs.io/docs/en/6.26.3/babelrc#use-via-packagejson
{ "babel": { "env": { // Specific configuration for each enviroment "test": { .... } } } }