-
Notifications
You must be signed in to change notification settings - Fork 38
Implement ApplicationCredentials #671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gndrmnn
wants to merge
10
commits into
k-orc:main
Choose a base branch
from
gndrmnn:implement_appcred
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
dd63faf
Scaffolding for the ApplicationCredential controller
gndrmnn c74168c
Scaffolding for the ApplicationCredential controller
gndrmnn 7214e21
Scaffolding for the ApplicationCredential controller
gndrmnn 6fa13d4
Scaffolding for the ApplicationCredential controller
gndrmnn af33297
ApplicationCredential Type Declaration
gndrmnn 89df1cc
ApplicationCredential Workaround for userID requirement in OpenStack API
gndrmnn 580c1cc
ApplicationCredential Regenerate Interfaces
gndrmnn 022f9fb
ApplicationCredential Actuator and Status
gndrmnn eaf6db9
ApplicationCredential Tests and Config Samples
gndrmnn 123212f
ApplicationCredential Additional Documentation
gndrmnn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,198 @@ | ||||||
| /* | ||||||
| Copyright The ORC Authors. | ||||||
|
|
||||||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||||||
| you may not use this file except in compliance with the License. | ||||||
| You may obtain a copy of the License at | ||||||
|
|
||||||
| http://www.apache.org/licenses/LICENSE-2.0 | ||||||
|
|
||||||
| Unless required by applicable law or agreed to in writing, software | ||||||
| distributed under the License is distributed on an "AS IS" BASIS, | ||||||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||
| See the License for the specific language governing permissions and | ||||||
| limitations under the License. | ||||||
| */ | ||||||
|
|
||||||
| package v1alpha1 | ||||||
|
|
||||||
| import metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||||||
|
|
||||||
| // +kubebuilder:validation:Enum:=CONNECT;DELETE;GET;HEAD;OPTIONS;PATCH;POST;PUT;TRACE | ||||||
| type HTTPMethod string | ||||||
|
|
||||||
| const ( | ||||||
| HTTPMethodCONNECT HTTPMethod = "CONNECT" | ||||||
| HTTPMethodDELETE HTTPMethod = "DELETE" | ||||||
| HTTPMethodGET HTTPMethod = "GET" | ||||||
| HTTPMethodHEAD HTTPMethod = "HEAD" | ||||||
| HTTPMethodOPTIONS HTTPMethod = "OPTIONS" | ||||||
| HTTPMethodPATCH HTTPMethod = "PATCH" | ||||||
| HTTPMethodPOST HTTPMethod = "POST" | ||||||
| HTTPMethodPUT HTTPMethod = "PUT" | ||||||
| HTTPMethodTRACE HTTPMethod = "TRACE" | ||||||
| ) | ||||||
|
|
||||||
| // ApplicationCredentialAccessRule defines an access rule | ||||||
| // +kubebuilder:validation:MinProperties:=1 | ||||||
| type ApplicationCredentialAccessRule struct { | ||||||
| // path that the application credential is permitted to access | ||||||
| // +kubebuilder:validation:MaxLength=1024 | ||||||
| // +optional | ||||||
| Path *string `json:"path,omitempty"` | ||||||
|
|
||||||
| // method that the application credential is permitted to use for a given API endpoint | ||||||
| // +optional | ||||||
| Method *HTTPMethod `json:"method,omitempty"` | ||||||
|
|
||||||
| // serviceRef identifier for the service that the application credential is permitted to access | ||||||
| // +optional | ||||||
| ServiceRef *KubernetesNameRef `json:"serviceRef,omitempty"` | ||||||
| } | ||||||
|
|
||||||
| // ApplicationCredentialResourceSpec contains the desired state of the resource. | ||||||
| // +kubebuilder:validation:XValidation:rule="self == oldSelf",message="ApplicationCredentialResourceSpec is immutable" | ||||||
| type ApplicationCredentialResourceSpec struct { | ||||||
| // name will be the name of the created resource. If not specified, the | ||||||
| // name of the ORC object will be used. | ||||||
| // +optional | ||||||
| Name *OpenStackName `json:"name,omitempty"` | ||||||
|
|
||||||
| // description is a human-readable description for the resource. | ||||||
| // +kubebuilder:validation:MinLength:=1 | ||||||
| // +kubebuilder:validation:MaxLength:=255 | ||||||
| // +optional | ||||||
| Description *string `json:"description,omitempty"` | ||||||
|
|
||||||
| // userRef is a reference to the ORC User which this resource is associated with. | ||||||
| // Note: Due to the nature of the OpenStack API, managing application credentials for a user different than the one ORC is authenticated against can be computationally expensive. In the worst case, all application credentials of all users have to be queried. | ||||||
| // +required | ||||||
| UserRef KubernetesNameRef `json:"userRef,omitempty"` | ||||||
|
|
||||||
| // unrestricted is a flag indicating whether the application credential may be used for creation or destruction of other application credentials or trusts | ||||||
| // +optional | ||||||
| Unrestricted *bool `json:"unrestricted,omitempty"` | ||||||
|
|
||||||
| // secret used to authenticate against the API | ||||||
| // +required | ||||||
| Secret ApplicationCredentialSecretSpec `json:"secret,omitempty,omitzero"` | ||||||
|
|
||||||
| // roleRefs may only contain roles that the user has assigned on the project. If not provided, the roles assigned to the application credential will be the same as the roles in the current token. | ||||||
| // +kubebuilder:validation:MaxItems:=256 | ||||||
| // +listType=atomic | ||||||
| // +optional | ||||||
| RoleRefs []KubernetesNameRef `json:"roleRefs,omitempty"` | ||||||
|
|
||||||
| // accessRules is a list of fine grained access control rules | ||||||
| // +kubebuilder:validation:MaxItems:=256 | ||||||
| // +listType=atomic | ||||||
| // +optional | ||||||
| AccessRules []ApplicationCredentialAccessRule `json:"accessRules,omitempty"` | ||||||
|
|
||||||
| // expiresAt is the time of expiration for the application credential. If unset, the application credential does not expire. | ||||||
| // +optional | ||||||
| ExpiresAt *metav1.Time `json:"expiresAt,omitempty"` | ||||||
| } | ||||||
|
|
||||||
| // +kubebuilder:validation:MinProperties:=1 | ||||||
| // +kubebuilder:validation:MaxProperties:=1 | ||||||
| type ApplicationCredentialSecretSpec struct { | ||||||
| // secretRef is a reference to a Secret containing the application credential secret | ||||||
| // +required | ||||||
| SecretRef KubernetesNameRef `json:"secretRef,omitempty"` | ||||||
| } | ||||||
|
|
||||||
| // ApplicationCredentialFilter defines an existing resource by its properties | ||||||
| // +kubebuilder:validation:MinProperties:=2 | ||||||
| type ApplicationCredentialFilter struct { | ||||||
| // userRef is a reference to the ORC User which this resource is associated with. | ||||||
| // Note: Due to the nature of the OpenStack API, managing application credentials for a user different than the one ORC is authenticated against can be computationally expensive. In the worst case, all application credentials of all users have to be queried. | ||||||
| // +required | ||||||
| UserRef KubernetesNameRef `json:"userRef,omitempty"` | ||||||
|
|
||||||
| // name of the existing resource | ||||||
| // +optional | ||||||
| Name *OpenStackName `json:"name,omitempty"` | ||||||
|
|
||||||
| // description of the existing resource | ||||||
| // +kubebuilder:validation:MaxLength:=1024 | ||||||
| // +optional | ||||||
| Description *string `json:"description,omitempty"` | ||||||
| } | ||||||
|
|
||||||
| type ApplicationCredentialAccessRoleStatus struct { | ||||||
| // name of an existing role | ||||||
| // +kubebuilder:validation:MaxLength:=1024 | ||||||
| // +optional | ||||||
| Name *string `json:"name,omitempty"` | ||||||
|
|
||||||
| // id is the ID of an role | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit
Suggested change
|
||||||
| // +kubebuilder:validation:MaxLength:=1024 | ||||||
| // +optional | ||||||
| ID *string `json:"id,omitempty"` | ||||||
|
|
||||||
| // domainID of the domain of this role | ||||||
| // +kubebuilder:validation:MaxLength:=1024 | ||||||
| // +optional | ||||||
| DomainID *string `json:"domainID,omitempty"` | ||||||
| } | ||||||
|
|
||||||
| type ApplicationCredentialAccessRuleStatus struct { | ||||||
| // id is the ID of this access rule | ||||||
| // +kubebuilder:validation:MaxLength:=1024 | ||||||
| // +optional | ||||||
| ID *string `json:"id,omitempty"` | ||||||
|
|
||||||
| // path that the application credential is permitted to access | ||||||
| // +kubebuilder:validation:MaxLength:=1024 | ||||||
| // +optional | ||||||
| Path *string `json:"path,omitempty"` | ||||||
|
|
||||||
| // method that the application credential is permitted to use for a given API endpoint | ||||||
| // +kubebuilder:validation:MaxLength=32 | ||||||
| // +optional | ||||||
| Method *string `json:"method,omitempty"` | ||||||
|
|
||||||
| // service type identifier for the service that the application credential is permitted to access | ||||||
| // +kubebuilder:validation:MaxLength:=1024 | ||||||
| // +optional | ||||||
| Service *string `json:"service,omitempty"` | ||||||
| } | ||||||
|
|
||||||
| // ApplicationCredentialResourceStatus represents the observed state of the resource. | ||||||
| type ApplicationCredentialResourceStatus struct { | ||||||
| // name is a Human-readable name for the resource. Might not be unique. | ||||||
| // +kubebuilder:validation:MaxLength=1024 | ||||||
| // +optional | ||||||
| Name string `json:"name,omitempty"` | ||||||
|
|
||||||
| // description is a human-readable description for the resource. | ||||||
| // +kubebuilder:validation:MaxLength=1024 | ||||||
| // +optional | ||||||
| Description string `json:"description,omitempty"` | ||||||
|
|
||||||
| // unrestricted is a flag indicating whether the application credential may be used for creation or destruction of other application credentials or trusts | ||||||
| // +optional | ||||||
| Unrestricted bool `json:"unrestricted,omitempty"` | ||||||
|
|
||||||
| // projectID of the project the application credential was created for and that authentication requests using this application credential will be scoped to. | ||||||
| // +kubebuilder:validation:MaxLength=1024 | ||||||
| // +optional | ||||||
| ProjectID string `json:"projectID,omitempty"` | ||||||
|
|
||||||
| // roles is a list of role objects may only contain roles that the user has assigned on the project | ||||||
| // +kubebuilder:validation:MaxItems:=64 | ||||||
| // +listType=atomic | ||||||
| // +optional | ||||||
| Roles []ApplicationCredentialAccessRoleStatus `json:"roles"` | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| // expiresAt is the time of expiration for the application credential. If unset, the application credential does not expire. | ||||||
| // +optional | ||||||
| ExpiresAt *metav1.Time `json:"expiresAt"` | ||||||
|
|
||||||
| // accessRules is a list of fine grained access control rules | ||||||
| // +kubebuilder:validation:MaxItems:=64 | ||||||
| // +listType=atomic | ||||||
| // +optional | ||||||
| AccessRules []ApplicationCredentialAccessRuleStatus `json:"accessRules,omitempty"` | ||||||
| } | ||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's no extra parameters associated with the secret, it's probably not necessary to wrap into a struct, is it?