docs: update sdlc-pipeline consensus wrapper for #2806 [doc-updater]#2828
Merged
Conversation
Update consensus wrapper description (item 6) to reflect changes from issue #2806 / PR #2811: - MAX_CONSENSUS_RESTARTS bumped from 2 to 3 - Each restart now emits a medium-priority OVERSEER_ALERT - Producer permanent death now hard-fails the pipeline (FAILED state) with a high-priority OVERSEER_ALERT rather than the generic single- agent HITL path; reviewer deaths still use the HITL path
Contributor
There was a problem hiding this comment.
No agent-mode design concerns. Documentation-only update synchronizing the consensus wrapper description with the behavior implemented in #2811.
— Authored by egg
This comment has been minimized.
This comment has been minimized.
Contributor
There was a problem hiding this comment.
Faithful, accurate doc update. Verified each claim against the code from #2811:
MAX_CONSENSUS_RESTARTSdefault 3 — matchesorchestrator/consensus_wrapper.py:38.- Per-restart medium-priority
OVERSEER_ALERT(anomalyagent-restart) — matchesorchestrator/consensus_wrapper.py:510-511(--anomaly agent-restart --priority medium). - Producer hard-fail with single re-query (race-window guard) — matches
orchestrator/routes/pipelines.py:18068-18099:filtered_graph.is_producer(role_value)gate,executor.check_consensus()recheck,continueonis_complete, otherwise fall through to_emit_producer_death_alertandreturn 1. - FAILED transition + high-priority
producer-permanent-deathalert withrestart_phase/cancel_taskguidance — matches_emit_producer_death_alertatorchestrator/routes/pipelines.py:15500-15580(subjectproducer-permanent-death: <role> exit=<N>[ slice=<id>] [high],metadata.anomaly_type == "producer-permanent-death", body names both recovery actions). - Reviewer-only deaths still flow through the existing single-agent HITL path — matches
orchestrator/routes/pipelines.py:18128-18132:handle_agent_failureis only called on theelsebranch when the role is not a producer. - Cross-link target
concurrent-execution.md#consensus-wrapperexists atdocs/guides/concurrent-execution.md:72, and the sister doc already describes the same behavior at lines 84-85, so the two guides are now consistent.
No correctness, robustness, security, or pattern concerns. Docs-only, single paragraph, no other files touched.
— Authored by egg
Contributor
Author
|
egg review completed. View run logs 1 previous review(s) hidden. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
docs/guides/sdlc-pipeline.mditem 6 in the concurrent phaseconsensus flow to reflect changes introduced in PR #2811 (fix #2806):
MAX_CONSENSUS_RESTARTSbumped from 2 → 3OVERSEER_ALERT(anomaly
agent-restart) so operators see recovery attempts in realtime instead of only at exhaustion
FAILED + emits high-priority
OVERSEER_ALERTwith anomalyproducer-permanent-death) rather than the generic single-agent HITLpath; reviewer deaths still use the HITL path
docs/guides/concurrent-execution.mdwas already updated as part of#2811.
Triggered by: 352378e Fix #2806: hard-fail pipeline on producer permanent death (#2811)
Authored-by: egg