Initial addon setup#1
Open
kevinmeijer97 wants to merge 4 commits into
Open
Conversation
BobWez98
approved these changes
May 19, 2026
| } catch (Throwable) { | ||
| return false; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
You can just do
Http::timeout(5)
->get('https://packagist.org/packages/justbetter/statamic-base.json')
->succesful()
->throw();i think and then you don't need the try catch
Member
Author
There was a problem hiding this comment.
Kept it how it is, with the throw you'd still need a try/catch or something like rescue().
| @@ -0,0 +1,49 @@ | |||
| <?php | |||
|
|
|||
| namespace JustBetter\StatamicBase\Services; | |||
Collaborator
There was a problem hiding this comment.
I would put this in a Client namespace
Member
Author
There was a problem hiding this comment.
I would disagree for this file, as this is not client related.
But i've moved src/Services/PackagistClient.php to src/Client/PackagistClient.php now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addon now adds a navigation item under the JustBetter namespace.
Currently, it links to an overview of installed JustBetter packages, where available updates are also displayed.