-
Notifications
You must be signed in to change notification settings - Fork 10
Feat/stats prom #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
julsemaan
wants to merge
6
commits into
master
Choose a base branch
from
feat/stats-prom
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/stats prom #74
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2bc471a
feat(api): add Prometheus metrics endpoint
julsemaan a82928a
feat(api): serve Prometheus metrics on a separate port
julsemaan f4e640b
feat(api): add shared error logging and configurable contact API URL
julsemaan 234ec2e
feat(api): bind metrics server to localhost by default
julsemaan cf40dfd
fix(api): normalize increment metric keys into buckets
julsemaan bf036ed
test(api): expect wildcard stats bucket key
julsemaan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package app | ||
|
|
||
| import "testing" | ||
|
|
||
| func TestLogURL(t *testing.T) { | ||
| t.Run("adds localhost for port only address", func(t *testing.T) { | ||
| got := logURL(":8080", "") | ||
| if got != "http://localhost:8080" { | ||
| t.Fatalf("expected localhost url, got %q", got) | ||
| } | ||
| }) | ||
|
|
||
| t.Run("uses host qualified address as is", func(t *testing.T) { | ||
| got := logURL("0.0.0.0:9090", "/metrics") | ||
| if got != "http://0.0.0.0:9090/metrics" { | ||
| t.Fatalf("expected host-qualified url, got %q", got) | ||
| } | ||
| }) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| package stats | ||
|
|
||
| import ( | ||
| "github.com/prometheus/client_golang/prometheus" | ||
| "github.com/prometheus/client_golang/prometheus/promauto" | ||
| ) | ||
|
|
||
| var statsHitsCounter = promauto.NewCounter(prometheus.CounterOpts{ | ||
| Name: "afn_stats_hits_total", | ||
| Help: "Number of accepted stats payloads.", | ||
| }) | ||
|
|
||
| var statsIncrementCounter = promauto.NewCounterVec( | ||
| prometheus.CounterOpts{ | ||
| Name: "afn_stats_increment_total", | ||
| Help: "Number of accepted increment stats by key.", | ||
| }, | ||
| []string{"key"}, | ||
| ) | ||
|
|
||
| type PrometheusMetrics struct{} | ||
|
|
||
| func NewPrometheusMetrics() *PrometheusMetrics { | ||
| return &PrometheusMetrics{} | ||
| } | ||
|
|
||
| func (m *PrometheusMetrics) IncrementStatsHits() { | ||
| statsHitsCounter.Inc() | ||
| } | ||
|
|
||
| func (m *PrometheusMetrics) IncrementKey(key string) { | ||
| statsIncrementCounter.WithLabelValues(key).Inc() | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified this is already addressed in the current branch.
Runno longer waits on the old error loop: metrics now run in a goroutine viaserveMetrics, andserveAPIreturns directly while treatinghttp.ErrServerClosedas a clean shutdown.