Support for multiple grouped / aggregated columns in pivoting#1145
Open
mattjubb wants to merge 4 commits intojtablesaw:masterfrom
Open
Support for multiple grouped / aggregated columns in pivoting#1145mattjubb wants to merge 4 commits intojtablesaw:masterfrom
mattjubb wants to merge 4 commits intojtablesaw:masterfrom
Conversation
benmccann
reviewed
Apr 19, 2023
| List<String> aggregatedColumnNames, | ||
| AggregateFunction<?, ?> aggregateFunction) { | ||
| return pivot( | ||
| groupingColumnNames.stream().map(this::categoricalColumn).collect(Collectors.toList()), |
Collaborator
There was a problem hiding this comment.
Codacy is complaining that you're doing Collectors.toList here when toList is already statically imported. I'm fine either way to want it as long as it's consistent
|
|
这是来自QQ邮箱的假期自动回复邮件。你好，我最近正在休假中，无法亲自回复你的邮件。我将在假期结束后，尽快给你回复。
|
Author
|
Could i get another review on this please? addressed previous feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing.
Description
obvious what the meaning of each argument is
Note: first time contributing to a project on github so let me know if i've done something wrong
Testing
yes added tests for 3 use cases 1) both multiple grouping and aggregation columns 2) multiple grouping and single aggregation 3) single grouping and