Some more fixes for decoding of headers#440
Open
fumpitz wants to merge 3 commits intojsuto:masterfrom
Open
Conversation
added 3 commits
March 31, 2026 17:23
- partial encoding of words (non-standard compliant but occurs in the wild) - multiline headers folded with TAB characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous fix #359 didn't handle TABs in folded headers completely.
Found and fixed a bug where a single quoted-printable encoded
b(e.g.=?iso-8859-1?Q?b?=) was mistakenly decoded as base64 encoding, becausestrcasestr(e, "?B?")grabbed the?b?instead of testing the?Q?. Switched to strncasecmp(...) to make sure only the first 3 characters are compared. Though this sounds weird, it can happen if an encoded header hits the length limit of a single encoded word.Added testcases for #359 and for TAB folding (plus single encoded
b)