Open
Conversation
2) Properly detect nanopi neo. 3) Fix incorrect pinmap values.
…hardware they want mocked if no hardware detected.
Owner
|
Thanks for this. Unfortunately there is a lot here I cannot use, there are a lot of superfluous changes and it doesn't take into account the sunxi support I already added. I will however look through and see if there is anything I can pull in individually. |
Author
|
I understand, take what you want and toss the rest.
…________________________________
From: Jonathan Perkin <notifications@github.com>
Sent: Monday, February 15, 2021 2:21 AM
To: jperkin/node-rpio <node-rpio@noreply.github.com>
Cc: Michael Jones <mike@indianajones.tv>; Author <author@noreply.github.com>
Subject: Re: [jperkin/node-rpio] Nanopi neo (#138)
Thanks for this. Unfortunately there is a lot here I cannot use, there are a lot of superfluous changes and it doesn't take into account the sunxi support I already added. I will however look through and see if there is anything I can pull in individually.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#138 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACYVGB33AO5VJEXVUHEEO5LS7DDPTANCNFSM4XTYQ3AA>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I corrected the pin values on the NanoPi, and also added NanoPi as a mock device.
I also moved the hard-coded 'defmock' into npio_options so users can choose the mock device if hardware not detected, rather then be stuck with raspi-3. It still uses rapsi-3 by default.