Replaces hash for sha256, and adds first iter for consistency#11
Open
sr-gi wants to merge 11 commits intojosibake:silent-payments-bipfrom
Open
Replaces hash for sha256, and adds first iter for consistency#11sr-gi wants to merge 11 commits intojosibake:silent-payments-bipfrom
sr-gi wants to merge 11 commits intojosibake:silent-payments-bipfrom
Conversation
undo the bip32 derivation changes, much simpler to keep it as two separately derived keys for now
Various fixes and clarifications
… change) Hashing a secret into the label, added footnote about worst-case implications of this when forgetting to increment k, explicitly added the 1023 character limit (5115 bytes), toned done wording of safety of collaborative transactions, made change label m=0, clarified the need to scan change label by default
Various important fixes (secret labels, security assumptions, limits, change)
Still better if there is a limit, but the rationale for the current limit made no sense
Co-authored-by: Vojtěch Strnad <43024885+vostrnad@users.noreply.github.com>
Fixed various typos and made clarifications. All hashes in Specification are now explicitly sha256. Made terminology "Y coordinate" and "X-only" consistent.
`sha256` is used as the hashing function up until "Using all inputs", from where `hash` is used. The same naming should be used for consistency. Furthermore, the example for all inputs does not include the step pace for `outpoint_hash`, but it does for `a`. Given they both use the same pace and number of iterations, it'll be best to make them look the same
josibake
force-pushed
the
silent-payments-bip
branch
7 times, most recently
from
b349517 to
d73e924
Compare
josibake
force-pushed
the
silent-payments-bip
branch
2 times, most recently
from
30cdd03 to
a2b52fe
Compare
josibake
force-pushed
the
silent-payments-bip
branch
from
1e10265 to
9912b88
Compare
josibake
force-pushed
the
silent-payments-bip
branch
from
73f1a52 to
359fa75
Compare
josibake
force-pushed
the
silent-payments-bip
branch
from
2857784 to
92b12ab
Compare
josibake
force-pushed
the
silent-payments-bip
branch
from
92b12ab to
f6dd067
Compare
josibake
force-pushed
the
silent-payments-bip
branch
2 times, most recently
from
9c82669 to
57c89ae
Compare
josibake
force-pushed
the
silent-payments-bip
branch
3 times, most recently
from
d8ed18c to
36fefe5
Compare
josibake
force-pushed
the
silent-payments-bip
branch
from
32a3293 to
82c2f78
Compare
josibake
force-pushed
the
silent-payments-bip
branch
2 times, most recently
from
a60bfc3 to
17e1d16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sha256is used as the hashing function up until "Using all inputs", from wherehashis used. The same naming should be used for consistency. Furthermore, the example for all inputs does not include the step pace foroutpoint_hash, but it does fora. Given they both use the same pace and number of iterations, it'll be best to make them look the same