Conversation
aa74cf7 to
62896e9
Compare
murchandamus
left a comment
There was a problem hiding this comment.
Reads well, really clear already. Left a few comments and suggestions.
bip-0000.mediawiki
Outdated
| **** Let ''t<sub>n</sub> = SHA256(SHA256(outpoint_hash·a·B<sub>scan</sub> || n))'' | ||
| **** Repeat with ''n++ for each additional output'' | ||
| * For each ''t<sub>n</sub>'': | ||
| ** Let ''P<sub>mn</sub> = t<sub>n</sub>·G + B<sub>m</sub>'' |
There was a problem hiding this comment.
Isn’t that obvious already, because the scan key is the same anyway?
Perhaps it should be explicitly pointed out somewhere that the labels are not sufficient to hide that multiple different addresses are owned by the same recipient. (It’s obvious to me, now that I think about it, but wasn’t at first until I realized that the other public key is still part of the address.)
bip-0000.mediawiki
Outdated
|
|
||
| * Let ''P<sub>0</sub> = HASH(a·B || 0)·G + B'' | ||
| * For additional outputs: | ||
| ** Let ''P<sub>i</sub> = HASH(a·B || n)·G + B'', where ''n'' starts from 1 and is incremented for each subsequent output |
There was a problem hiding this comment.
Shouldn't i and n be the same letter here?
71ac688 to
c709095
Compare
|
Hello! Overall, this is a interesting idea, and I enjoyed reading the draft. Since this payment method is being proposed specifically to offer strong theoretical privacy properties, I thought I would take a look. My background is in research cryptography, so my focus while reading the document was on analyzing the mathematical parts in the Overview section for the listed goal privacy properties. I read the entire Overview section, and I haven't found any issues with the cryptography being used (with regards to the listed goals). The two goals I looked at the most carefully (and are most cryptographic in nature) were:
Here are a few other thoughts I have from a cryptographer's perspective:
|
|
@nikkisigurdson thanks for taking the time to look over the proposal. It's reassuring to hear you haven't come across any issues with the cryptography being used.
Thanks again for sharing your thoughts, this was helpful. |
54b4581 to
80963fb
Compare
theStack
left a comment
There was a problem hiding this comment.
Concept ACK
Left some comments below, a deeper review round will follow soon (tm)
d7f78d8 to
d9c2f28
Compare
Various edits, most importantly around P2TR
9408154 to
ecd936d
Compare
Co-authored-by: RubenSomsen <rsomsen@gmail.com>
b4ac7fd to
f0ccab1
Compare
|
opened against the bips repo here: bitcoin#1458 |
Add backwards compatibility section
No description provided.