isSelectorInViewport and isSelectorEntirelyInViewport#132
Merged
ingvar-snow merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
ingvar-snow
changed the title
ingvar-snow
changed the title
ingvar-snow
force-pushed
the
pro/PRO-14499-is-in-viewport-checks
branch
2 times, most recently
from
e8663ef to
97eda01
Compare
uid11
changed the title
Added `isSelectorInViewport` and `isSelectorEntirelyInViewport` tests; refactor their implementations to use Playwright
ingvar-snow
force-pushed
the
pro/PRO-14499-is-in-viewport-checks
branch
from
97eda01 to
ee9ac33
Compare
uid11
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
Fixes for correct building and running e2ed on macOS.
Add
isSelectorInViewportandisSelectorEntirelyInViewporttests; refactor their implementations to use Playwright.