Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions .github/workflows/rust-port-convergence.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,14 @@ jobs:
real-engine-lifecycle-smoke:
name: Real Engine Lifecycle Smoke
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
include:
- runner: docker
smoke_target: real-engine-lifecycle-smoke-docker
- runner: podman
smoke_target: real-engine-lifecycle-smoke-podman
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -101,14 +109,24 @@ jobs:
- name: Setup Rust
uses: dtolnay/rust-toolchain@stable

- name: Build release binary
run: cargo build --release --manifest-path cmd/devcontainer/Cargo.toml

- name: Docker version
run: docker version
- name: Install Podman Compose
if: matrix.runner == 'podman'
run: |
sudo apt-get update
sudo apt-get install -y podman podman-compose

- name: Runtime version
run: |
if [[ "${{ matrix.runner }}" == "podman" ]]; then
podman version
podman-compose version
else
docker version
docker compose version
fi

- name: Real engine lifecycle smoke
run: ./scripts/standalone/real-engine-smoke.sh ./cmd/devcontainer/target/release/devcontainer
run: make ${{ matrix.smoke_target }}

upstream-convergence:
name: Upstream Convergence Baseline
Expand Down
11 changes: 11 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
rust-check \
rust-tests \
build-release \
real-engine-lifecycle-smoke \
real-engine-lifecycle-smoke-docker \
real-engine-lifecycle-smoke-podman \
standalone-artifact-smoke \
pypi-wheel-smoke \
native-only-startup-contract \
Expand Down Expand Up @@ -44,6 +47,14 @@ rust-tests:
build-release:
cargo build --release --manifest-path $(RUST_MANIFEST)

real-engine-lifecycle-smoke: real-engine-lifecycle-smoke-docker real-engine-lifecycle-smoke-podman

real-engine-lifecycle-smoke-docker: build-release
./scripts/standalone/real-engine-smoke.sh $(RELEASE_BINARY)

real-engine-lifecycle-smoke-podman: build-release
./scripts/standalone/real-engine-smoke.sh $(RELEASE_BINARY) --docker-path podman --docker-compose-path podman-compose

standalone-artifact-smoke: build-release
./scripts/standalone/smoke.sh $(RELEASE_BINARY)

Expand Down
20 changes: 1 addition & 19 deletions cmd/devcontainer/src/runtime/compose/args.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,27 +2,9 @@

use std::path::PathBuf;

use crate::commands::common;

use super::ComposeSpec;

pub(super) fn compose_args(spec: &ComposeSpec, subcommand: &str, tail: &[&str]) -> Vec<String> {
compose_args_with_override(spec, subcommand, tail, None)
}

pub(super) fn compose_args_with_override(
spec: &ComposeSpec,
subcommand: &str,
tail: &[&str],
override_file: Option<&PathBuf>,
) -> Vec<String> {
compose_args_owned(
spec,
subcommand,
override_file,
tail.iter().map(|value| value.to_string()).collect(),
)
}
use crate::commands::common;

pub(super) fn compose_args_owned(
spec: &ComposeSpec,
Expand Down
31 changes: 14 additions & 17 deletions cmd/devcontainer/src/runtime/compose/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ use crate::commands::configuration;
use super::context::ResolvedConfig;
use super::engine;

const COMPOSE_PROJECT_LABEL: &str = "com.docker.compose.project";
const COMPOSE_SERVICE_LABEL: &str = "com.docker.compose.service";

pub(crate) struct ComposeSpec {
pub(crate) files: Vec<PathBuf>,
pub(crate) service: String,
Expand Down Expand Up @@ -182,19 +185,6 @@ pub(crate) fn up_service(
Ok(())
}

pub(crate) fn remove_service(resolved: &ResolvedConfig, args: &[String]) -> Result<(), String> {
let spec = load_compose_spec(resolved)?
.ok_or_else(|| "Compose configuration was expected but not found".to_string())?;
let result = engine::run_compose(
args,
args::compose_args(&spec, "rm", &["-s", "-f", &spec.service]),
)?;
if result.status_code != 0 {
return Err(engine::stderr_or_stdout(&result));
}
Ok(())
}

pub(crate) fn resolve_container_id(
resolved: &ResolvedConfig,
args: &[String],
Expand All @@ -216,12 +206,19 @@ fn resolve_container_id_with_options(
) -> Result<Option<String>, String> {
let spec = load_compose_spec(resolved)?
.ok_or_else(|| "Compose configuration was expected but not found".to_string())?;
let mut ps_args = vec!["-q"];
let mut ps_args = vec!["ps".to_string(), "-q".to_string()];
if include_stopped {
ps_args.push("-a");
ps_args.push("-a".to_string());
}
ps_args.push(&spec.service);
let result = engine::run_compose(args, args::compose_args(&spec, "ps", &ps_args))?;
ps_args.push("--filter".to_string());
ps_args.push(format!(
"label={COMPOSE_PROJECT_LABEL}={}",
spec.project_name
));
ps_args.push("--filter".to_string());
ps_args.push(format!("label={COMPOSE_SERVICE_LABEL}={}", spec.service));

let result = engine::run_engine(args, ps_args)?;
if result.status_code != 0 {
return Err(engine::stderr_or_stdout(&result));
}
Expand Down
4 changes: 2 additions & 2 deletions cmd/devcontainer/src/runtime/container/discovery.rs
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ fn ensure_compose_up_container(
let remove_existing = common::has_flag(args, "--remove-existing-container");
if let Some(container_id) = compose::resolve_container_id(resolved, args)? {
if remove_existing {
compose::remove_service(resolved, args)?;
remove_container(args, &container_id)?;
return create_compose_container(resolved, args, image_name, remote_workspace_folder);
}
return refresh_compose_container(
Expand All @@ -105,7 +105,7 @@ fn ensure_compose_up_container(

if let Some(container_id) = compose::resolve_container_id_including_stopped(resolved, args)? {
if remove_existing {
compose::remove_service(resolved, args)?;
remove_container(args, &container_id)?;
return create_compose_container(resolved, args, image_name, remote_workspace_folder);
}
return refresh_compose_container(
Expand Down
Loading
Loading