Skip to content

fix(http): reset is_ntlm_probe after Type 3 auth to prevent duplicate request #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonwiggins wants to merge 1 commit into from
Closed

fix(http): reset is_ntlm_probe after Type 3 auth to prevent duplicate request #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion crates/liburlx/src/easy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3480,7 +3480,7 @@ async fn perform_transfer(
// For NTLM, send Content-Length: 0 (body will be sent after Type3).
let is_challenge_response = !has_digest_state
&& auth_credentials.as_ref().is_some_and(|a| matches!(a.method, AuthMethod::Digest));
let is_ntlm_probe =
let mut is_ntlm_probe =
auth_credentials.as_ref().is_some_and(|a| matches!(a.method, AuthMethod::Ntlm));
let initial_body = if is_challenge_response || is_ntlm_probe {
if current_body.is_some() {
Expand Down Expand Up @@ -4229,6 +4229,11 @@ async fn perform_transfer(
fail_on_error,
))
.await?;

// NTLM Type 3 auth complete — reset probe flag so the
// probe-retry logic (line ~3638) does not re-send the
// request on the already-successful 200 response.
is_ntlm_probe = false;
}
}
}
Expand Down
Loading