Skip to content

fix(http): prevent connection reuse when --fail skips response body (test 1328) #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonwiggins wants to merge 1 commit into from
Closed

fix(http): prevent connection reuse when --fail skips response body (test 1328) #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion crates/liburlx/src/protocol/http/h1.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,7 +823,16 @@ where
// Determine if connection can be reused
let server_wants_close =
ph.headers.get("connection").is_some_and(|v| v.eq_ignore_ascii_case("close"));
let can_reuse = keep_alive && !use_http10 && !server_wants_close && !body_read_to_eof;
// When --fail skips the body, unread data remains on the socket. Don't reuse
// the connection if the response had body framing (Content-Length or chunked),
// because the next request would read stale body bytes as headers (curl compat: test 1328).
let has_body_framing = ph.headers.contains_key("content-length")
|| ph.headers.get("transfer-encoding").is_some_and(|te| te_contains_chunked(te));
let can_reuse = keep_alive
&& !use_http10
&& !server_wants_close
&& !body_read_to_eof
&& !(fail_skip && has_body_framing);

let mut resp = Response::new(ph.status, ph.headers, response_body, url.to_string());
resp.set_header_original_names(ph.original_names);
Expand Down
Loading