Harden tests and coverage checks by jonmartin721 · Pull Request #21 · jonmartin721/devwatch-github

jonmartin721 · 2026-03-09T00:54:49Z

Summary

add an explicit coverage script and make validate run coverage
fail tests on unexpected console error and warn output by default
update noisy tests to mock expected console calls cleanly

Testing

npm run validate
full jest coverage run in pre-push hook

gemini-code-assist · 2026-03-09T00:55:11Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the robustness of the test suite by integrating comprehensive code coverage checks into the validation workflow and enforcing stricter control over console output during tests. These changes aim to improve code quality, prevent silent errors, and ensure that all console messages are intentionally handled, leading to a more reliable and maintainable codebase.

Highlights

Enhanced Test Coverage: A dedicated test:coverage script was introduced, and the main validate command was updated to include comprehensive code coverage checks, ensuring that coverage is always part of the standard validation process.
Stricter Console Output Handling: A global console guard was implemented in tests/setup.js to automatically fail tests that produce unexpected console.error or console.warn output, promoting cleaner test environments and preventing silent issues.
Updated Test Files for Console Mocks: Multiple test files (background.test.js, export-import-controller.test.js, options-main.test.js, options.test.js, phase1.test.js, state-manager.test.js) were updated to explicitly mock console.error and console.warn where expected, aligning with the new console guard policy.
Refactored Chrome API Mocks: Chrome API mocks in tests/setup.js were refactored for improved consistency and maintainability, including the addition of a mock for chrome.runtime.lastError.
Enabled Previously Skipped Test: A previously skipped test in tests/options-token-controller.test.js was enabled, along with an added mock for chrome.storage.local.set, expanding test coverage for token management.

Changelog

package.json
- Added test:coverage script.
- Updated validate script to use test:coverage.
tests/background.test.js
- Added jest.spyOn(console, 'error') and jest.spyOn(console, 'warn') mocks in beforeEach and restored them in afterEach.
tests/export-import-controller.test.js
- Added jest.spyOn(console, 'error') mock in beforeEach and restored it in afterEach.
tests/options-main.test.js
- Added jest.spyOn(console, 'error') mock in beforeEach and restored it in afterEach.
tests/options-token-controller.test.js
- Added a mock implementation for chrome.storage.local.set.
- Unskipped the clearToken clears all fields when confirmed test.
tests/options.test.js
- Added jest.spyOn(console, 'error') mock in beforeEach and restored it in afterEach.
tests/phase1.test.js
- Added jest.spyOn(console, 'error') mocks in beforeEach and restored them in afterEach for 'Dark Mode' and 'Error Display' describe blocks.
tests/setup.js
- Refactored chrome.storage mocks into a createStorageArea helper function.
- Added chrome.runtime.lastError mock.
- Implemented a global console guard (installConsoleGuard, allowUnexpectedConsole) to catch unexpected console.error and console.warn calls, failing tests if unhandled.
tests/state-manager.test.js
- Added jest.spyOn(console, 'error') mock in beforeEach and restored it in afterEach.

Activity

The pull request was created by jonmartin721.
The pull request includes changes to package.json and several test files to harden testing and coverage checks.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

sentry · 2026-03-09T00:56:01Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

gemini-code-assist

Code Review

This pull request effectively hardens the test suite by introducing coverage checks and a global guard against unexpected console logs. No vulnerabilities or significant security issues were found in the provided changes. My feedback focuses on a couple of areas for improvement: refactoring duplicated test setup code for better maintainability, and removing a redundant mock that is now covered by the enhanced global test setup.

gemini-code-assist · 2026-03-09T00:56:21Z

tests/background.test.js

+    jest.spyOn(console, 'error').mockImplementation(() => {});
+    jest.spyOn(console, 'warn').mockImplementation(() => {});
+  });
+
+  afterEach(() => {
+    console.error.mockRestore();
+    console.warn.mockRestore();
  });


This pattern of mocking console.error and console.warn in beforeEach/afterEach is repeated across several test files (export-import-controller.test.js, options-main.test.js, etc.). To improve maintainability and reduce code duplication, consider creating a shared test utility. For example, you could create a helper function in a test utility file that sets up these mocks, and then call it in the describe block of the relevant test suites.

gemini-code-assist · 2026-03-09T00:56:21Z

tests/options-token-controller.test.js

+    chrome.storage.local.set.mockImplementation((items, callback) => {
+      if (callback) callback();
+    });


The global test setup in tests/setup.js now provides a comprehensive mock for chrome.storage.local.set that handles callbacks and returns a promise. This local mock is now redundant and can be removed. The global mock is sufficient for the clearToken test to pass.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0e06972b50

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-09T00:58:26Z

tests/setup.js

+        state.allowed ||
+        console[method] !== state.guard ||
+        state.guard.getMockImplementation() !== state.initialImplementation;


Keep console guard active when tests replace mock implementation

This logic treats any test that calls console.error.mockImplementation(...) or console.warn.mockImplementation(...) as "explicitly handled", so unexpected extra console output is never reported for that test. In this same commit several suites now install broad console.error spies in beforeEach, which effectively disables the new hardening and allows regressions that add new warnings/errors to pass silently.

Useful? React with 👍 / 👎.

Harden tests and coverage checks

0e06972

gemini-code-assist bot reviewed Mar 9, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Mar 9, 2026

View reviewed changes

jonmartin721 added 3 commits March 8, 2026 21:15

Tighten console guard handling in tests

1e72428

Merge origin/main into touchup/testing-hardening

f627473

Tighten console guard test coverage

bd50ef2

jonmartin721 merged commit 8457f9c into main Mar 11, 2026
2 checks passed

jonmartin721 deleted the touchup/testing-hardening branch March 11, 2026 21:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Harden tests and coverage checks#21

Harden tests and coverage checks#21
jonmartin721 merged 4 commits intomainfrom
touchup/testing-hardening

jonmartin721 commented Mar 9, 2026

Uh oh!

gemini-code-assist bot commented Mar 9, 2026

Uh oh!

sentry bot commented Mar 9, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Mar 9, 2026

Uh oh!

gemini-code-assist bot Mar 9, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

jonmartin721 commented Mar 9, 2026

Summary

Testing

Uh oh!

gemini-code-assist bot commented Mar 9, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

sentry bot commented Mar 9, 2026

Codecov Report

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant