fix(v2): remove manual walletname encoding and rely on generated client path serialization #1209
Merged
theborakompanioni merged 4 commits intojoinmarket-webui:v2from Apr 16, 2026
Conversation
47b502a to
67063b8
Compare
parrth20
approved these changes
Apr 16, 2026
Member
|
@Ashish-Kumar-Dash LGTM thanks! |
Contributor
Author
|
Hey! I agree & have added a small regression unit test, do check it out |
Contributor
Author
|
yup yup I was fixing them only, didn't expect for a review to be this fast :) |
theborakompanioni
approved these changes
Apr 16, 2026
theborakompanioni
pushed a commit
that referenced
this pull request
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes manual walletname URL encoding at generated-client callsites and standardizes on passing raw walletname values.
Why
The generated API client already encodes path params internally. Pre-encoding at callsites can cause double-encoding edge cases, especially for wallets created outside Jam.
What changed
Validation
Notes
No functional API shape changes were introduced; this is a consistency and safety cleanup.