Skip to content

chore: remove switch wallet page#1207

Merged
theborakompanioni merged 1 commit intodevelfrom
tbk/rm-switch-wallet
Apr 16, 2026
Merged

chore: remove switch wallet page#1207
theborakompanioni merged 1 commit intodevelfrom
tbk/rm-switch-wallet

Conversation

@theborakompanioni
Copy link
Copy Markdown
Collaborator

@theborakompanioni theborakompanioni commented Apr 15, 2026

Removes the SwitchWalletPage component as it is unfinished and not really needed.
If a user wants so switch a wallet, he can lock or "log out" of the current wallet and choose a different one.

@theborakompanioni theborakompanioni self-assigned this Apr 15, 2026
@theborakompanioni theborakompanioni added enhancement New feature or request tech dept Removes some technical debt labels Apr 15, 2026
@theborakompanioni theborakompanioni marked this pull request as ready for review April 15, 2026 19:02
@parrth20
Copy link
Copy Markdown
Member

@theborakompanioni looks mostly clean and good , but one leftover from the switchwallet page removal is still present,

the English locale removes wallets.alert_wallet_open and settings.button_switch_wallet, but the same switch-wallet-only keys still exist in the other locale files. Since the page, route, and settings link are gone, can you remove those keys from de, fr, it, pt_BR, ru, zh_Hans, and zh_Hant too?

if you want me i can also commit that changes ?

@parrth20
Copy link
Copy Markdown
Member

@theborakompanioni or we can make a follow-up for this what you think?

@theborakompanioni
Copy link
Copy Markdown
Collaborator Author

@theborakompanioni or we can make a follow-up for this what you think?

Yes, we need to cleanup i18n handling from the ground up anyway. But lets first focus on features, unused i18n keys is a concern in the cleanup phase before releasing v2.

@theborakompanioni theborakompanioni merged commit 4500ca4 into devel Apr 16, 2026
3 checks passed
@theborakompanioni theborakompanioni deleted the tbk/rm-switch-wallet branch April 16, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request tech dept Removes some technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants