feat(wallet): add data-journey-state attribute to MainWalletPage#1206
Open
23bsm038-Mahi wants to merge 1 commit intojoinmarket-webui:v2from
Open
feat(wallet): add data-journey-state attribute to MainWalletPage#120623bsm038-Mahi wants to merge 1 commit intojoinmarket-webui:v2from
23bsm038-Mahi wants to merge 1 commit intojoinmarket-webui:v2from
Conversation
Contributor
Author
|
@theborakompanioni Hi, I added a small data-journey-state attribute to the main wallet container as a first step towards making the UI state-aware. Kept the change minimal and non-breaking. Please let me know if you’d prefer this in a different place or any changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Added a data-journey-state attribute to the main wallet container.
Why:
This is a small step towards making the wallet UI more state-aware, so we can guide users better in future.
Scope:
Just a minimal UI change, no logic or behavior is modified.
Notes:
I couldn’t find MainWalletView in the current codebase, so I applied this in MainWalletPage instead. Let me know if there’s a better place for this.
Also, I noticed some test differences locally due to number formatting (locale-related), but this change doesn’t touch any of that.