InterfaceManager: add unique IDs for listeners#132
Open
blackBeaRR wants to merge 5 commits intojoinframework:mainfrom
Open
InterfaceManager: add unique IDs for listeners#132blackBeaRR wants to merge 5 commits intojoinframework:mainfrom
blackBeaRR wants to merge 5 commits intojoinframework:mainfrom
Conversation
mrabine
requested changes
Feb 21, 2026
mrabine
requested changes
Feb 27, 2026
mrabine
reviewed
Feb 27, 2026
| { | ||
| ScopedLock <Mutex> lock (_linkMutex); | ||
| _linkListeners.push_back (cb); | ||
| return _linkListeners.emplace(_listenersCounter.fetch_add(1, std::memory_order::memory_order_acq_rel) + 1, cb).first->first; |
Collaborator
There was a problem hiding this comment.
it is always protected by the mutex so atomic is not needed at all in fact.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
- Coverage 96.24% 96.24% -0.01%
==========================================
Files 77 77
Lines 9249 9238 -11
==========================================
- Hits 8902 8891 -11
Misses 347 347
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.