Skip to content

Fixes #332 - get_ref_info()#333

Merged
munoztd0 merged 3 commits into
devfrom
332_get_ref_info-bug
May 26, 2026
Merged

Fixes #332 - get_ref_info()#333
munoztd0 merged 3 commits into
devfrom
332_get_ref_info-bug

Conversation

@wwojciech
Copy link
Copy Markdown
Collaborator

@wwojciech wwojciech commented May 14, 2026

Fixes #332

Checks

  • (Have you updated the NEWS.md ?)
  • (Have you added proper tests for new functions/features ?)
  • (Have you added new functions to the pkgdown.yml ?)
  • (Have you run document() on new functions ?)

@wwojciech wwojciech requested review from iaugusty and munoztd0 May 14, 2026 12:48
@wwojciech wwojciech self-assigned this May 14, 2026
@wwojciech wwojciech added the bug Something isn't working label May 14, 2026
@wwojciech wwojciech changed the title Fixes get_ref_info() - #332 Fixes #332 - get_ref_info() May 14, 2026
@wwojciech wwojciech linked an issue May 15, 2026 that may be closed by this pull request
[Bug]: junco::get_ref_info() fails in the presence of rtables::add_overall_col(). #332
Open
munoztd0
munoztd0 approved these changes May 18, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@munoztd0 munoztd0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wwojciech
Copy link
Copy Markdown
Collaborator Author

wwojciech commented May 19, 2026

Hi @iaugusty - would you like to review this PR, or can we merge it? Thanks!

iaugusty
iaugusty approved these changes May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@iaugusty iaugusty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approach will work, under the condition that the used afun knows how to deal with incoming .in_ref_col = NULL and .ref_group = NULL situation, which not all afuns will

@munoztd0
Copy link
Copy Markdown
Collaborator

munoztd0 commented May 26, 2026

Checking insightsengineering/scda.test#233
perform a check using scda.test, if it would impact our TLG catalog

@munoztd0
Copy link
Copy Markdown
Collaborator

munoztd0 commented May 26, 2026

Checking insightsengineering/scda.test#233 perform a check using scda.test, if it would impact our TLG catalog

All good on scda.test (the one error is due to sdtm changes not this PR)

@munoztd0 munoztd0 merged commit cb9143f into dev May 26, 2026
1 of 5 checks passed
@munoztd0 munoztd0 deleted the 332_get_ref_info-bug branch May 26, 2026 14:13
@wwojciech
Copy link
Copy Markdown
Collaborator Author

wwojciech commented May 26, 2026

Checking insightsengineering/scda.test#233 perform a check using scda.test, if it would impact our TLG catalog

All good on scda.test (the one error is due to sdtm changes not this PR)

Thank you @munoztd0 !

munoztd0 added a commit that referenced this pull request May 26, 2026
@wwojciech @munoztd0
Fixes #332 - get_ref_info() (#333)
0ddb44e 
* fixes get_ref_info() - #332

* Update NEWS.md

---------

Co-authored-by: David Muñoz Tord <david.munoz@mailbox.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@munoztd0 munoztd0 munoztd0 approved these changes

@iaugusty iaugusty iaugusty approved these changes

Assignees

@wwojciech wwojciech

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: junco::get_ref_info() fails in the presence of rtables::add_overall_col().

3 participants

@wwojciech @munoztd0 @iaugusty