Open
Conversation
Add accurate GPU memory accounting in lombscargle: import skcuda.fft and include cufft plan workspace estimates (using cufftEstimate1d) for FFT buffers, fix incorrect mem overwrite by using += for FFT buffers, add regularization term to memory tally, and correct per-batch sizing by moving the nbatch multiplication to the end (adjust sparse matrix/vector sizing accordingly). These changes ensure the memory estimator accounts for FFT plan work areas and per-batch allocation correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add accurate GPU memory accounting in lombscargle: import skcuda.fft and include cufft plan workspace estimates (using cufftEstimate1d) for FFT buffers, fix incorrect mem overwrite by using += for FFT buffers, add regularization term to memory tally, and correct per-batch sizing by moving the nbatch multiplication to the end (adjust sparse matrix/vector sizing accordingly). These changes ensure the memory estimator accounts for FFT plan work areas and per-batch allocation correctly.