Open
Conversation
Introduces a new Checkbox component rendered using shapes instead of Unicode characters or PDF form fields. - Adds checkbox component and props - Implements rendering in gofpdf provider - Includes unit tests, examples, and golden tests - Addresses issue #488 This component is visual-only by design and aligns with Maroto v2 layout philosophy.
Owner
Author
|
Hey @vamshi1188, unfortunately the checkbox feature is not working properly with the grid system. |
3 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #552 +/- ##
==========================================
- Coverage 88.06% 86.68% -1.37%
==========================================
Files 61 64 +3
Lines 2360 2491 +131
==========================================
+ Hits 2078 2159 +81
- Misses 246 293 +47
- Partials 36 39 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
Author
|
I did part of it yesterday, can you add that checkmark that you added in your version? I guess you only have to change this part: https://github.com/johnfercher/maroto/blob/master/internal/providers/gofpdf/checkbox.go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Checklist
func (<first letter of struct> *struct) method() {}name style.when,shouldnaming pattern.m := mocks.NewConstructor(t).m.EXPECT().MethodName()method to mock methods.example_test.go.make dodwith none issues pointed out bygolangci-lint