feature: add richtext support#551
Open
avdoseferovic wants to merge 1 commit intojohnfercher:masterfrom
Open
Conversation
Author
|
@johnfercher how do you feel about this one? |
|
up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before this PR, maroto's text component applies a single style to the entire string , if you
need one bold word in a sentence, you'd have to split it across multiple columns and manually
align them. This is fragile and doesn't support word wrapping across style boundaries.
Tricky Technical Details:
Word wrapping across chunk boundaries
Each chunk can have a different font/size, so a word's pixel width depends on which chunk it
belongs to. The layout algorithm splits all chunks into individual words (preserving their style
association), then measures each word with its own font to decide line breaks. This means a
wrap can happen mid-chunk.
Related Issue
#189
Checklist
func (<first letter of struct> *struct) method() {}name style.when,shouldnaming pattern.m := mocks.NewConstructor(t).m.EXPECT().MethodName()method to mock methods.example_test.go.make dodwith none issues pointed out bygolangci-lint