Skip to content

Added UMD definition to allow requireJs and CommonJs#32

Open
togakangaroo wants to merge 1 commit intojohnculviner:masterfrom
togakangaroo:master
Open

Added UMD definition to allow requireJs and CommonJs#32
togakangaroo wants to merge 1 commit intojohnculviner:masterfrom
togakangaroo:master

Conversation

@togakangaroo
Copy link
Copy Markdown

Fix for this issue: #31

And fixed the gitignore file (it was not actually ignoring the bin directories)

@togakangaroo
Copy link
Copy Markdown
Author

Any movement on this?

@johnculviner
Copy link
Copy Markdown
Owner

I'm getting a "We can’t automatically merge this pull request." from Github and the diff has every single line changing so I've been hesitant to integrate it for sake of stability. I'll have to run it though a different diff tool than what Github has because I think the indents are confusing it. If we can get a diff that just shows the header and footer of the file changing (which is all it is right?) I can put it in right away. Sorry for the delay

@togakangaroo
Copy link
Copy Markdown
Author

Been a while but yeah, I'm pretty sure that's all it is. I'm using it in my current project.

Thanks for the response and thanks for the tool.

Sent from Mailbox for iPad

On Fri, Jan 24, 2014 at 10:40 AM, John Culviner notifications@github.com
wrote:

I'm getting a "We can’t automatically merge this pull request." from Github and the diff has every single line changing so I've been hesitant to integrate it for sake of stability. I'll have to run it though a different diff tool than what Github has because I think the indents are confusing it. If we can get a diff that just shows the header and footer of the file changing (which is all it is right?) I can put it in right away. Sorry for the delay

Reply to this email directly or view it on GitHub:
#32 (comment)

@Kushagra8888 Kushagra8888 mentioned this pull request Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants