feat: added metamodule config & amends to resolve compiler warnings#2
Open
jackregnart wants to merge 1 commit intojjbbllkk:mainfrom
Open
feat: added metamodule config & amends to resolve compiler warnings#2jackregnart wants to merge 1 commit intojjbbllkk:mainfrom
jackregnart wants to merge 1 commit intojjbbllkk:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added required metamodule config by creating:
The one thing you might not appreciate about this commit is I renamed the brand to
Vulpes79Portsto distinguish it from the Acid Gen repo. It's convention with VCV Rack repos to have all the modules in the same repo so that they all fit under the same brand. It doesn't matter so much in the end with VCV Rack. However, the metamodule compiles all the modules into a single filemetamodule-plugins/Vulpes79Ports.mmpluginI had to use a different brand otherwise themetamodule-plugins/Vulpes79.mmpluginfile I created for the AcidGen module would get overwritten.Happy for the brand to be changed, or if you wanted to roll this into the other repo to keep them in the same place then that also makes sense.
To compile the metamodule plugin follow the guidelines here https://github.com/4ms/metamodule-plugin-sdk