fix(app-test-cases): correct decisions-log phase tag (3-commcare, not 6-qa-and-training)#401
Merged
Merged
Conversation
… 6-qa-and-training) `app-test-cases/SKILL.md` recorded its decisions-log rows with `phase: 6-qa-and-training` even though the skill is dispatched from `agents/commcare-setup.md § Step 2.6` (Phase 3). The convention used by every other writer skill is "the phase the skill is dispatched in," and the artifact manifest already maps the producer's output to `3-commcare/app-test-cases.yaml` (see `lib/artifact-manifest.ts:383`). The `6-qa-and-training` tag was a mismatch — rows would group under the wrong phase in the rendered decisions.gdoc and confuse the Phase Write-Back Verifier's per-phase row-count checks (when those land). No data migration needed — issue #399 surfaced that this skill had written zero rows in practice (the bug it documented), so there's no historical decisions.yaml content tagged with the old phase. Flagged inline in commcare-setup.md by PR #400 as a follow-up. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #400 / #399.
skills/app-test-cases/SKILL.mdrecorded its decisions-log rows withphase: 6-qa-and-trainingeven though the skill is dispatched fromagents/commcare-setup.md § Step 2.6(Phase 3).Convention used by every other writer skill (verified): the
phase:tag in the Decisions Log footer is the phase the skill is dispatched in, not where its outputs are consumed. The artifact manifest already mapsapp-test-cases.yamlto3-commcare/(lib/artifact-manifest.ts:383), so3-commcareis the consistent tag.What changed
skills/app-test-cases/SKILL.md: headerPhase 6→Phase 3; footerphase: 6-qa-and-training→phase: 3-commcare. Added a note explaining the dispatching-phase convention so the next reader doesn't recreate the mismatch.agents/commcare-setup.mdStep 2.6: removed the inline "upstream mismatch" disclaimer that PR fix(decisions-log): enumerate decisions.yaml writes in every phase agent (closes #399) #400 added (the upstream is now correct).No migration needed
Issue #399 documented that this skill wrote zero rows in practice, so no historical
decisions.yamlcontent carries the old phase tag.Test plan
/ace:runproducesapp-test-casesrows indecisions.yamltaggedphase: 3-commcare.decisions.gdocgroups them under Phase 3, not Phase 6.🤖 Generated with Claude Code