fix(videos): play overlay no longer blocks the native scrubber#457
Merged
Conversation
@jjackson reported: "I can't drag the time slider forward or back successfully, it just resumes playing where it is." Cause: PR #450 turned the play overlay into a real <button> with `absolute inset-0`, which covered the entire video including the native controls strip at the bottom. Before first play, the user trying to drag the scrubber clicked the overlay button instead, which called v.play() from the original currentTime (= 0). From the user's perspective the seek did nothing and the video started over. Fix: shrink the overlay to a centered round affordance (the same visual but positioned with `top-1/2 left-1/2 -translate-*` instead of `inset-0`). Native scrubber / play / volume / fullscreen controls along the bottom are always reachable. Verified geometry: with the player at 768×432px, the button is 68×68 centered, leaving 182px of clear space below it — well clear of the ~40px native controls strip. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@jjackson reported: "I can't drag the time slider forward or back successfully, it just resumes playing where it is."
Cause: PR #450 turned the play overlay into a real
<button>withabsolute inset-0, which covered the entire video including the native controls strip at the bottom. Before first play, a user trying to drag the scrubber clicked the overlay button instead, which calledv.play()from the originalcurrentTime(= 0). From the user's perspective the seek did nothing and the video just started over.Fix
Shrink the overlay to a centered round affordance — same visual, just positioned with
top-1/2 left-1/2 -translate-*instead ofinset-0. Native scrubber / play / volume / fullscreen along the bottom are always reachable.Verified
Playwright geometry probe on the chc editor page (player at 768×432):
The 68×68 round button sits in the visual center; the native controls strip ~40px tall along the bottom has 182px of clear space above it.
🤖 Generated with Claude Code