Allow the name/version@user/channel reference format#404
Open
anders-zpt wants to merge 2 commits intojfrog:mainfrom
Open
Allow the name/version@user/channel reference format#404anders-zpt wants to merge 2 commits intojfrog:mainfrom
name/version@user/channel reference format#404anders-zpt wants to merge 2 commits intojfrog:mainfrom
Conversation
Contributor
|
We do not support conan 1.x so this is redundant, We have only added support for conan 2.x. |
Author
|
This PR is not about Conan 1.x support in general. It's just about supporting the format |
name/version@user/channel reference format
Author
|
@reshmifrog we still have a lot of packages in the old format and won't be able to use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
With the switch from output parsing to reading the JSON file, the support for Conan 1.x style package references was dropped.
Solution:
This PR re-adds support for parsing out the
userandchannelfields from a Conan 1.x style package reference and formats the Artifactory URL with these values. It reuses theParsePackageReferencefunction already in the repo.