Skip to content

Allow the name/version@user/channel reference format#404

Open
anders-zpt wants to merge 2 commits intojfrog:mainfrom
zeropoint-tech:conan-allow-user-channel-in-package-ref
Open

Allow the name/version@user/channel reference format#404
anders-zpt wants to merge 2 commits intojfrog:mainfrom
zeropoint-tech:conan-allow-user-channel-in-package-ref

Conversation

@anders-zpt
Copy link
Copy Markdown

Problem:
With the switch from output parsing to reading the JSON file, the support for Conan 1.x style package references was dropped.

Solution:
This PR re-adds support for parsing out the user and channel fields from a Conan 1.x style package reference and formats the Artifactory URL with these values. It reuses the ParsePackageReference function already in the repo.

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • Appropriate label is added to auto generate release notes.
  • I used gofmt for formatting the code before submitting the pull request.
  • PR description is clear and concise, and it includes the proposed solution/fix.

@reshmifrog
Copy link
Copy Markdown
Contributor

We do not support conan 1.x so this is redundant, We have only added support for conan 2.x.

@anders-zpt
Copy link
Copy Markdown
Author

This PR is not about Conan 1.x support in general. It's just about supporting the format user/version@name/channel. I'm happy to change the PR title

@anders-zpt anders-zpt changed the title Allow Conan 1.x style package references Allow the name/version@user/channel reference format Mar 24, 2026
@anders-zpt
Copy link
Copy Markdown
Author

@reshmifrog we still have a lot of packages in the old format and won't be able to use the jf conan command until a fix like this is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants