APP-1823 - Support dry run in application CLI#62
Merged
Conversation
Contributor
shayshim
force-pushed
the
feature/APP-1823
branch
from
e490be8 to
44b9838
Compare
asafgabai
reviewed
Feb 9, 2026
| } | ||
|
|
||
| if response.StatusCode != http.StatusCreated { | ||
| // Dry run returns http.StatusOK |
Collaborator
There was a problem hiding this comment.
After Yuri's PR is merged, let's make sure it's valid also when async == true.
asafgabai
reviewed
Feb 9, 2026
| expectedError: "", | ||
| }, | ||
| { | ||
| name: "success with dry-run (201 Created)", |
Collaborator
There was a problem hiding this comment.
Why do we need to test both 200 and 201? Does this request return 201 sometimes?
shayshim
force-pushed
the
feature/APP-1823
branch
from
44b9838 to
51f9bdd
Compare
shayshim
force-pushed
the
feature/APP-1823
branch
from
51f9bdd to
f006882
Compare
shayshim
force-pushed
the
feature/APP-1823
branch
from
f006882 to
e71d269
Compare
asafgabai
reviewed
Feb 15, 2026
| } | ||
|
|
||
| if response.StatusCode != expectedStatusCode { | ||
| if !apphttp.IsSuccessStatusCode(response.StatusCode) { |
Collaborator
There was a problem hiding this comment.
I'm ok with this approach, but it'd be better to change it for all commands (or use the previous approach 🙃)
Collaborator
Author
There was a problem hiding this comment.
I changed other instances in the same file to use the new approach, which is a bit more readable
asafgabai
reviewed
Feb 15, 2026
| endpoint := fmt.Sprintf("/v1/applications/%s/versions/", request.ApplicationKey) | ||
| response, responseBody, err := ctx.GetHttpClient().Post(endpoint, request, map[string]string{"async": strconv.FormatBool(!sync)}) | ||
| response, responseBody, err := ctx.GetHttpClient().Post(endpoint, request, | ||
| map[string]string{"async": strconv.FormatBool(!sync), "dry_run": strconv.FormatBool(dryRun)}) |
shayshim
force-pushed
the
feature/APP-1823
branch
from
e71d269 to
7a1caea
Compare
shayshim
force-pushed
the
feature/APP-1823
branch
from
7a1caea to
e6ef7e9
Compare
asafgabai
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainbranch.go vet ./....go fmt ./....