build-info-extractor-gradle: use container api for configuration cach…#705
Open
martin-walsh wants to merge 1 commit intojfrog:masterfrom
Open
build-info-extractor-gradle: use container api for configuration cach…#705martin-walsh wants to merge 1 commit intojfrog:masterfrom
martin-walsh wants to merge 1 commit intojfrog:masterfrom
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
github-actions
bot
removed
the
safe to test
Author
|
@yahavi How can I start a discussion on this ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this PR as a conversation starter around support for new
--configuration-cacheflag in Gradle.Essentially, if a project uses any plugins which do not defer creation of Tasks, a user cannot make use of configuration cache.
The main changes required are to use the lazy init apis i.e.
registervscreate&namedvsfindByName.The code looks like it requires more changes than I have made here so far, but before I do so, it's best to discuss.
See: